Ped Support and better Gabz Support in config

Merge pull request #5 from jimathy/jimathy-patch-2
Debug mode + Custom Ticket Cashin + Gabz Locations
2026-08-17 06:16:02 +01:00 · 2022-04-20 13:52:32 +01:00 · 2022-04-19 21:32:35 +01:00 · 2022-04-19 21:32:12 +01:00 · 2022-04-19 21:30:08 +01:00 · 2022-04-19 21:26:43 +01:00
7 changed files with 396 additions and 186 deletions
--- a/README.md
+++ b/README.md
@@ -46,12 +46,7 @@ Go to [qb] > qb-phone > client > main.lua

 - Add this line:

-```TriggerServerEvent('jim-payments:Tickets:Give', amount, society)```
-
--------------
-
-NOTE: If you are converting from my older job scripts, I recommend removing the previous triggers from qb-phone
-
+```TriggerServerEvent('jim-payments:Tickets:Give', data)```

 --------------

@@ -61,3 +56,15 @@ simply look in the atms.lua and change the config options at the top
 Choose wether to use atm's, choose wether to use banking locations
 Choose wether to add bank blips (if you want to disable qb-banking)
 Choose wether to add ATM blips (if you like $ signs)
+
+
+--------------
+
+New Commission system added
+
+This brings more config options to find tune the script
+
+Choose wether people get commission from every sale
+Choose if EVERY worker gets Commission that is on duty
+Choose if Commission is limited by MinAmountForTicket
+Choose if the worker charging the customer gets double commission
--- a/atms.lua
+++ b/atms.lua
@@ -3,91 +3,12 @@ local QBCore = exports['qb-core']:GetCoreObject()
 -- This script is a simple replacement for QB-Banking and QB-ATMs
 -- It uses QB-Input and server callbacks to retreive info about accounts and cash
 -- This requires QB-Target and has the location of every ATM, ATM prop and bank window
-- If Config.useATM = false, then none of this load

-Config.ATMModels = {"prop_atm_01", "prop_atm_02", "prop_atm_03", "prop_fleeca_atm" }
-
-Config.ATMLocations = {
-  --PACIFIC BANK 10 ATMS
-	vector3(265.9, 213.86, 106.28),	
-	vector3(265.56, 212.98, 106.28),
-	vector3(265.19, 211.91, 106.28),
-	vector3(264.86, 211.03, 106.28),
-	vector3(264.52, 210.06, 106.28),
-	vector3(236.64, 219.72, 106.29),
-	vector3(237.04, 218.72, 106.29),
-	vector3(237.5, 217.87, 106.29),
-	vector3(237.93, 216.94, 106.29),
-	vector3(238.36, 216.03, 106.29),
-	
-	--WALL ATMS
-	vector3(-386.54, 6046.29, 31.5),
-	vector3(-282.82, 6226.24, 31.49),
-	vector3(-132.74, 6366.79, 31.48),
-	vector3(-95.76, 6457.41, 31.46),
-	vector3(-97.52, 6455.65, 31.47),
-	vector3(155.95, 6642.99, 31.6),
-	vector3(173.92, 6638.16, 31.57),
-	vector3(2558.65, 350.92, 108.62),
-	vector3(1077.78, -776.64, 58.35),
-	vector3(1138.14, -468.88, 66.73),
-	vector3(1166.93, -455.96, 66.81),
-	vector3(285.37, 143.07, 104.17),
-	vector3(-165.43, 234.81, 94.92),
-	vector3(-165.4, 232.73, 94.92),
-	vector3(-1410.41, -98.76, 52.43),
-	vector3(-1409.85, -100.51, 52.38),
-	vector3(-1206.0, -324.94, 37.86),
-	vector3(-1205.23, -326.55, 37.86),
-	vector3(-2072.28, -317.27, 13.32),
-	vector3(-2974.7, 380.15, 15.0),
-	vector3(-2959.01, 487.45, 15.46),
-	vector3(-2956.87, 487.36, 15.46),
-	vector3(-3043.98, 594.32, 7.74),
-	vector3(-3241.35, 997.74, 12.55),
-	vector3(-1305.59, -706.64, 25.32),
-	vector3(-537.85, -854.69, 29.28),
-	vector3(-709.98, -818.71, 23.73),
-	vector3(-712.87, -818.71, 23.73),
-	vector3(-526.71, -1223.18, 18.45),
-	vector3(-256.47, -715.94, 33.55),
-	vector3(-259.13, -723.29, 33.54),
-	vector3(-203.82, -861.3, 30.27),
-	vector3(111.38, -774.96, 31.44),
-	vector3(114.56, -776.13, 31.42),
-	vector3(112.46, -819.65, 31.34),
-	vector3(118.93, -883.68, 31.12),
-	vector3(-846.97, -340.29, 38.68),
-	vector3(-846.41, -341.41, 38.68),
-	vector3(-262.21, -2012.17, 30.15),
-	vector3(-273.23, -2024.32, 30.15),
-	vector3(24.46, -945.94, 29.36),
-	vector3(-254.48, -692.74, 33.61),
-	vector3(-1569.95, -546.94, 34.96),
-	vector3(-1570.91, -547.63, 34.96),
-	vector3(289.14, -1282.29, 29.6),
-	vector3(289.18, -1256.84, 29.44),
-	vector3(296.04, -896.22, 29.24),
-	vector3(296.74, -894.26, 29.24),
-	vector3(-301.63, -829.73, 32.43),
-	vector3(-303.23, -829.44, 32.43),
-	vector3(5.27, -919.87, 29.56),
-	vector3(-1200.61, -885.62, 13.26),
-}
-
-Config.BankLocations = {
-    vector3(149.9, -1040.46, 29.37),
-    vector3(314.23, -278.83, 54.17),
-    vector3(-350.8, -49.57, 49.04),
-    vector3(-1213.0, -330.39, 37.79),
-    vector3(-2962.71, 483.0, 15.7),
-    vector3(1175.07, 2706.41, 38.09),
-    vector3(247.44, 223.22, 106.29),
-    vector3(-113.22, 6470.03, 31.63),
-	vector3(242.25, 225.15, 106.29)
-	--vector3(252.41, 221.41, 106.29)
-}
+local Targets = {}
+local Peds = {}

+local BankLoc = Config.VanBankLocations
+local ATMLoc = Config.VanATMLocations

 local function cv(amount)
    local formatted = amount
@@ -99,10 +20,23 @@ local function cv(amount)
    end
    return formatted
 end
+
 local function createBlips()
+	if Config.Gabz then BankLoc = Config.GabzBankLocations ATMLoc = Config.GabzATMLocations end
 	if Config.useATM then
 		if Config.ATMBlips then
-			for k, v in pairs(Config.ATMLocations) do
+			for k, v in pairs(Config.WallATMLocations) do
+				blip = AddBlipForCoord(v)
+				SetBlipSprite(blip, 108)
+				SetBlipDisplay(blip, 4)
+				SetBlipScale(blip, 0.55)
+				SetBlipColour(blip, 3)
+				SetBlipAsShortRange(blip, true)
+				BeginTextCommandSetBlipName("STRING")
+				AddTextComponentString("ATM")
+				EndTextCommandSetBlipName(blip)
+			end
+			for k, v in pairs(ATMLoc) do
 				blip = AddBlipForCoord(v)
 				SetBlipSprite(blip, 108)
 				SetBlipDisplay(blip, 4)
@@ -117,16 +51,19 @@ local function createBlips()
 	end
 	if Config.useBanks then
 		if Config.BankBlips then
-			for k, v in pairs(Config.BankLocations) do
-				blip = AddBlipForCoord(v)
-				SetBlipSprite(blip, 108)
-				SetBlipDisplay(blip, 4)
-				SetBlipScale(blip, 0.55)
-				SetBlipColour(blip, 2)
-				SetBlipAsShortRange(blip, true)
-				BeginTextCommandSetBlipName("STRING")
-				AddTextComponentString("Bank")
-				EndTextCommandSetBlipName(blip)
+			for k,v in pairs(BankLoc) do
+				for l, b in pairs(v) do
+					blip = AddBlipForCoord(b)
+					SetBlipSprite(blip, 108)
+					SetBlipDisplay(blip, 4)
+					SetBlipScale(blip, 0.55)
+					SetBlipColour(blip, 2)
+					SetBlipAsShortRange(blip, true)
+					BeginTextCommandSetBlipName("STRING")
+					AddTextComponentString("Bank")
+					EndTextCommandSetBlipName(blip)
+					break
+				end
 			end
 		end
 	end
@@ -136,20 +73,20 @@ AddEventHandler('onResourceStart', function(resource) if GetCurrentResourceName(

 RegisterNetEvent('QBCore:Client:OnPlayerLoaded', function() createBlips() end)

+local bossroles = {}
+local gangroles = {}
 Citizen.CreateThread(function()
 	if Config.useATM or Config.useBanks then
-		local bossroles = {}
-		for k, v in pairs(QBCore.Shared.Jobs) do 
-			for l, b in pairs(QBCore.Shared.Jobs[tostring(k)].grades) do
-				if QBCore.Shared.Jobs[tostring(k)].grades[l].isboss == true then
-					if bossroles[tostring(k)] ~= nil then
-						if bossroles[tostring(k)] > tonumber(l) then bossroles[tostring(k)] = tonumber(l) end
+		for k, v in pairs(QBCore.Shared.Jobs) do ---Grabs the list of jobs
+			for l, b in pairs(QBCore.Shared.Jobs[tostring(k)].grades) do -- Grabs the list of grades
+				if QBCore.Shared.Jobs[tostring(k)].grades[l].isboss == true then -- Checks the grade if is boss
+					if bossroles[tostring(k)] ~= nil then -- checks if the line exists
+						if bossroles[tostring(k)] > tonumber(l) then bossroles[tostring(k)] = tonumber(l) end -- the 
 					else bossroles[tostring(k)] = tonumber(l)
 					end
 				end
 			end
 		end
-		local gangroles = {}
 		for k, v in pairs(QBCore.Shared.Gangs) do 
 			for l, b in pairs(QBCore.Shared.Gangs[tostring(k)].grades) do
 				if tostring(k) ~= "none" then
@@ -159,31 +96,49 @@ Citizen.CreateThread(function()
 						else gangroles[tostring(k)] = tonumber(l)
 						end
 					end
-
 				end	
 			end
 		end
 	end
 	if Config.useATM then
 		exports['qb-target']:AddTargetModel(Config.ATMModels, { options = { { event = "jim-payments:Client:ATM:use", icon = "fas fa-money-check-alt", label = "Use ATM", id = "atm" },}, distance = 1.5, })
-		for k,v in pairs(Config.ATMLocations) do
-			exports['qb-target']:AddCircleZone("jimatm"..k, vector3(tonumber(v.x), tonumber(v.y), tonumber(v.z)+0.2), 0.5, { name="jimatm"..k, debugPoly=false, useZ=true, }, 
+		for k,v in pairs(Config.WallATMLocations) do
+			Targets["jimwallatm"..k] =
+			exports['qb-target']:AddCircleZone("jimwallatm"..k, vector3(tonumber(v.x), tonumber(v.y), tonumber(v.z)+0.2), 0.5, { name="jimwallatm"..k, debugPoly=Config.Debug, useZ=true, }, 
 			{ options = { { event = "jim-payments:Client:ATM:use", icon = "fas fa-money-check-alt", label = "Use ATM", id = "atm" },
-						  --[[{ event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Transfer Money", id = "transfer" },]] }, distance = 1.5 })
+						  --{ event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Transfer Money", id = "transfer" },
+			}, distance = 1.5 })
+		end
+		for k,v in pairs(ATMLoc) do
+			Targets["jimatm"..k] =
+			exports['qb-target']:AddCircleZone("jimatm"..k, vector3(tonumber(v.x), tonumber(v.y), tonumber(v.z)+0.2), 0.5, { name="jimatm"..k, debugPoly=Config.Debug, useZ=true, }, 
+			{ options = { { event = "jim-payments:Client:ATM:use", icon = "fas fa-money-check-alt", label = "Use ATM", id = "atm" },
+						  --{ event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Transfer Money", id = "transfer" },
+			}, distance = 1.5 })
 		end
 	end
 	if Config.useBanks then
-		for k,v in pairs(Config.BankLocations) do
-			exports['qb-target']:AddCircleZone("jimbank"..k, vector3(tonumber(v.x), tonumber(v.y), tonumber(v.z)), 2.0, { name="jimbank"..k, debugPoly=false, useZ=true, }, 
-			{ options = { { event = "jim-payments:Client:ATM:use", icon = "fas fa-piggy-bank", label = "Use Bank", id = "bank" },
-						  { event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Transfer Money", id = "transfer" },
-						  { event = "jim-payments:Client:ATM:use", icon = "fas fa-money-check-dollar", label = "Access Savings", id = "savings" },
-						  
-						  { event = "jim-payments:Client:ATM:use", icon = "fas fa-building", label = "Access Society Account", id = "society", job = bossroles },
-						  { event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Society Money Transfer", id = "societytransfer", job = bossroles },
-						  
-						  { event = "jim-payments:Client:ATM:use", icon = "fas fa-building", label = "Gang Society Account", id = "gang", gang = gangroles },
-						  { event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Gang Money Transfer", id = "gangtransfer", gang = gangroles }, }, distance = 2.5 })
+		for k,v in pairs(BankLoc) do
+			for l, b in pairs(v) do
+				Targets["jimbank"..k..l] =
+				exports['qb-target']:AddCircleZone("jimbank"..k..l, vector3(tonumber(b.x), tonumber(b.y), tonumber(b.z)+0.2), 2.0, { name="jimbank"..k..l, debugPoly=Config.Debug, useZ=true, }, 
+				{ options = { { event = "jim-payments:Client:ATM:use", icon = "fas fa-piggy-bank", label = "Use Bank", id = "bank" },
+							  { event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Transfer Money", id = "transfer" },
+							  { event = "jim-payments:Client:ATM:use", icon = "fas fa-money-check-dollar", label = "Access Savings", id = "savings" },
+													  
+							  { event = "jim-payments:Client:ATM:use", icon = "fas fa-building", label = "Access Society Account", id = "society", job = bossroles },
+							  { event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Society Money Transfer", id = "societytransfer", job = bossroles },
+							  
+							  { event = "jim-payments:Client:ATM:use", icon = "fas fa-building", label = "Gang Society Account", id = "gang", gang = gangroles },
+							  { event = "jim-payments:Client:ATM:use", icon = "fas fa-arrow-right-arrow-left", label = "Gang Money Transfer", id = "gangtransfer", gang = gangroles }, }, 
+				distance = 2.5 })
+				if Config.Peds then
+					local i = math.random(1, #Config.PedPool)
+					RequestModel(Config.PedPool[i]) while not HasModelLoaded(Config.PedPool[i]) do Wait(0) end
+					if Peds["jimbank"..k..l] == nil then Peds["jimbank"..k..l] = CreatePed(0, Config.PedPool[i], vector3(tonumber(b.x), tonumber(b.y), tonumber(b.z)), b[4], false, false) end
+					if Config.Debug then print("Ped Created - 'jimbank"..k..l.."'") end
+				end
+			end
 		end
 	end
 end)
@@ -199,26 +154,29 @@ local function PlayATMAnimation(animation)
 	end
 end

+local function GrabAccount(type, job)
+	local p = promise.new()
+	QBCore.Functions.TriggerCallback('jim-payments:ManageWrapper', function(cb) p:resolve(cb) end, type, job)
+	return Citizen.Await(p)
+end
+
 RegisterNetEvent('jim-payments:Client:ATM:use', function(data)
 	--this grabs all the info from names to savings account numbers in the databases
 	while name == nil do 
 	QBCore.Functions.TriggerCallback('jim-payments:ATM:Find', function(cb1, cb2, cb3, cb4, cb5, cb6, cb7) name = cb1 cash = cb2 bank = cb3 account = cb4 cid = cb5 savbal = cb6 aid = cb7 end) 
 		Citizen.Wait(100) 
 	end
-	while society == nil do 
-	QBCore.Functions.TriggerCallback('qb-bossmenu:server:GetAccount', function(cb) society = cb end, PlayerJob.name)
-		Citizen.Wait(100) 
-	end	
-	while gsociety == nil do 
-	QBCore.Functions.TriggerCallback('qb-gangmenu:server:GetAccount', function(cb) gsociety = cb end, PlayerGang.name)
-		Citizen.Wait(100) 
-	end
+	
+	society = GrabAccount("GetAccount", PlayerJob.name) 
+	Wait(200)
+	gsociety = GrabAccount("GetGangAccount", PlayerGang.name)
+	
 	local atmbartime = 2500
 	local setoptions = {}

 	if data.id == "atm" then
 		setoptions = { { value = "withdraw", text = "Withdrawl" }, }
-		setview = "Welcome back, "..name.."<br><br>- Citizen ID -<br>"..cid.."<br><br>- Balances -<br>🏦Bank - $"..cv(bank).."<br>💵Cash - $"..cv(cash)..'<br><br>- Options -'
+		setview = "<center><img src=https://static.wikia.nocookie.net/gtawiki/images/b/bd/Fleeca-GTAV-Logo.png width=200px></center><br>Welcome back, "..name.."<br><br>- Citizen ID -<br>"..cid.."<br><br>- Balances -<br>🏦Bank - $"..cv(bank).."<br>💵Cash - $"..cv(cash)..'<br><br>- Options -'
 		setheader = "💵 ATM Banking 💵"
 		setinputs = { { type = 'radio', name = 'billtype', text = setview, options = setoptions },
 					  { type = 'number', isRequired = true, name = 'amount', text = '💵 Amount to transfer' }, }
@@ -374,3 +332,10 @@ RegisterNetEvent('jim-payments:client:ATM:give', function()
 		end
 	end)
 end)
+
+AddEventHandler('onResourceStop', function(resource) 
+	if resource == GetCurrentResourceName() then 
+		for k, v in pairs(Targets) do exports['qb-target']:RemoveZone(k) end		
+		for k, v in pairs(Peds) do DeletePed(Peds[k]) end
+	end
+end)
--- a/atmserver.lua
+++ b/atmserver.lua
@@ -13,13 +13,20 @@ end


 ---- BANK STUFF
+QBCore.Functions.CreateCallback('jim-payments:ManageWrapper', function(source, cb, type, account)
+	local result = nil
+	if type == "GetAccount" then result = exports["qb-management"]:GetAccount(account) end
+	if type == "GetGangAccount" then result = exports["qb-management"]:GetGangAccount(account) end
+	cb(result) 
+end)
+
 RegisterServerEvent('jim-payments:server:ATM:use', function(amount, billtype, baccount, account, society, gsociety)
 	local src = source
 	local Player = QBCore.Functions.GetPlayer(src)
 	local cashB = Player.Functions.GetMoney("cash")
 	local bankB = Player.Functions.GetMoney("bank")
 	local amount = tonumber(amount)
-			--TriggerClientEvent("QBCore:Notify", src, tostring(account), "error")
+	--TriggerClientEvent("QBCore:Notify", src, tostring(account), "error")

 	--Simple transfers from bank to wallet --
 	if account == "bank" or account == "atm" then
@@ -72,12 +79,14 @@ RegisterServerEvent('jim-payments:server:ATM:use', function(amount, billtype, ba
 			elseif tonumber(society) >= amount then
 				TriggerClientEvent("QBCore:Notify", src, "Withdrew $"..cv(amount).." from the "..Player.PlayerData.job.label.." account", "success")
 				Player.Functions.AddMoney('bank', amount)
-				TriggerEvent("qb-bossmenu:server:removeAccountMoney", tostring(Player.PlayerData.job.name), amount)
+				if Config.Manage then exports["qb-management"]:RemoveMoney(tostring(Player.PlayerData.job.name), amount)
+				else TriggerEvent("qb-bossmenu:server:removeAccountMoney", tostring(Player.PlayerData.job.name), amount) end
 			end
 		elseif billtype == "deposit" then
 			if bankB < amount then TriggerClientEvent("QBCore:Notify", src, "Not enough money in your bank", "error")
 			elseif bankB >= amount then
-				TriggerEvent("qb-bossmenu:server:addAccountMoney", tostring(Player.PlayerData.job.name), amount)
+				if Config.Manage then exports["qb-management"]:AddMoney(tostring(Player.PlayerData.job.name), amount)
+				else TriggerEvent("qb-bossmenu:server:addAccountMoney", tostring(Player.PlayerData.job.name), amount) end
 				Player.Functions.RemoveMoney('bank', amount) Wait(1500)
 				TriggerClientEvent("QBCore:Notify", src, "Deposited $"..cv(amount).." into the "..Player.PlayerData.job.label.." account", "success")
 			end
@@ -100,7 +109,8 @@ RegisterServerEvent('jim-payments:server:ATM:use', function(amount, billtype, ba
 			local result = MySQL.Sync.fetchAll('SELECT * FROM players WHERE charinfo LIKE ?', {query})
 			if result[1] ~= nil then
 				local Reciever = QBCore.Functions.GetPlayerByCitizenId(result[1].citizenid)
-				TriggerEvent("qb-bossmenu:server:removeAccountMoney", tostring(Player.PlayerData.job.name), amount)
+				if Config.Manage then exports["qb-management"]:RemoveMoney(tostring(Player.PlayerData.job.name), amount)
+				else TriggerEvent("qb-bossmenu:server:removeAccountMoney", tostring(Player.PlayerData.job.name), amount) end
 				if Reciever ~= nil then
 					Reciever.Functions.AddMoney('bank', amount)
 					TriggerClientEvent("QBCore:Notify", src, "Sent $"..amount.." to "..Reciever.PlayerData.charinfo.firstname.." "..Reciever.PlayerData.charinfo.lastname, "success")
@@ -121,12 +131,14 @@ RegisterServerEvent('jim-payments:server:ATM:use', function(amount, billtype, ba
 			elseif tonumber(gsociety) >= amount then
 				TriggerClientEvent("QBCore:Notify", src, "Withdrew $"..cv(amount).." from the "..Player.PlayerData.gang.label.." account", "success")
 				Player.Functions.AddMoney('bank', amount)
-				TriggerEvent("qb-gangmenu:server:removeAccountMoney", tostring(Player.PlayerData.gang.name), amount)
+				if Config.Manage then exports["qb-management"]:RemoveGangMoney(tostring(Player.PlayerData.gang.name), amount)
+				else TriggerEvent("qb-gangmenu:server:removeAccountMoney", tostring(Player.PlayerData.gang.name), amount) end
 			end
 		elseif billtype == "deposit" then
 			if bankB < amount then TriggerClientEvent("QBCore:Notify", src, "Not enough money in your bank", "error")
 			elseif bankB >= amount then
-				TriggerEvent("qb-gangmenu:server:addAccountMoney", tostring(Player.PlayerData.gang.name), amount)
+				if Config.Manage then exports["qb-management"]:AddGangMoney(tostring(Player.PlayerData.gang.name), amount)
+				else TriggerEvent("qb-gangmenu:server:addAccountMoney", tostring(Player.PlayerData.gang.name), amount) end
 				Player.Functions.RemoveMoney('bank', amount) Wait(1500)
 				TriggerClientEvent("QBCore:Notify", src, "Deposited $"..cv(amount).." into the "..Player.PlayerData.gang.label.." account", "success")
 			end
@@ -149,7 +161,8 @@ RegisterServerEvent('jim-payments:server:ATM:use', function(amount, billtype, ba
 			local result = MySQL.Sync.fetchAll('SELECT * FROM players WHERE charinfo LIKE ?', {query})
 			if result[1] ~= nil then
 				local Reciever = QBCore.Functions.GetPlayerByCitizenId(result[1].citizenid)
-				TriggerEvent("qb-bossmenu:server:removeAccountMoney", tostring(Player.PlayerData.gang.name), amount)
+				if Config.Manage then exports["qb-management"]:RemoveGangMoney(tostring(Player.PlayerData.gang.name), amount)
+				else TriggerEvent("qb-bossmenu:server:removeAccountMoney", tostring(Player.PlayerData.gang.name), amount) end
 				if Reciever ~= nil then
 					Reciever.Functions.AddMoney('bank', amount)
 					TriggerClientEvent("QBCore:Notify", src, "Sent $"..amount.." to "..Reciever.PlayerData.charinfo.firstname.." "..Reciever.PlayerData.charinfo.lastname, "success")
@@ -213,6 +226,7 @@ QBCore.Functions.CreateCallback('jim-payments:ATM:Find', function(source, cb)
        savbal = getSavingsAccount[1].amount
 	else 
 		MySQL.Async.insert('INSERT INTO bank_accounts (citizenid, amount, account_type) VALUES (?, ?, ?)', { Player.PlayerData.citizenid, 0, 'Savings' }, function() completed = true end) repeat Wait(0) until completed == true
+		local getSavingsAccount = MySQL.Sync.fetchAll('SELECT * FROM bank_accounts WHERE citizenid = ? AND account_type = ?', { Player.PlayerData.citizenid, 'Savings' })
 		aid = getSavingsAccount[1].record_id
 		savbal = getSavingsAccount[1].amount
    end
@@ -233,7 +247,7 @@ RegisterServerEvent("jim-payments:server:ATM:give", function(citizen, price)
 			Player.Functions.RemoveMoney('cash', amount)
 			TriggerClientEvent("QBCore:Notify", source, "You gave "..Reciever.PlayerData.charinfo.firstname.." $"..cv(amount), "success")
 			Reciever.Functions.AddMoney('cash', amount)
-			TriggerClientEvent("QBCore:Notify", tonumber(citizen), "You got $"..cv(amount).." from "..Reciever.PlayerData.charinfo.firstname, "success")
+			TriggerClientEvent("QBCore:Notify", tonumber(citizen), "You got $"..cv(amount).." from "..Player.PlayerData.charinfo.firstname, "success")
 		elseif balance < amount then
 			TriggerClientEvent("QBCore:Notify", source, "You don't have enough cash to give", "error")
 		end
--- a/client.lua
+++ b/client.lua
@@ -2,7 +2,7 @@ local QBCore = exports['qb-core']:GetCoreObject()

 PlayerJob = {}
 local onDuty = false
-
+local BankPed = nil
 RegisterNetEvent('QBCore:Client:OnPlayerLoaded') AddEventHandler('QBCore:Client:OnPlayerLoaded', function() QBCore.Functions.GetPlayerData(function(PlayerData) PlayerJob = PlayerData.job PlayerGang = PlayerData.gang end) end)
 RegisterNetEvent('QBCore:Client:OnJobUpdate') AddEventHandler('QBCore:Client:OnJobUpdate', function(JobInfo) PlayerJob = JobInfo onDuty = PlayerJob.onduty end)
 RegisterNetEvent('QBCore:Client:SetDuty') AddEventHandler('QBCore:Client:SetDuty', function(duty) onDuty = duty end)
@@ -14,8 +14,15 @@ AddEventHandler('onResourceStart', function(resource) if GetCurrentResourceName(
 Citizen.CreateThread(function()
 	local jobroles = {}
 	for k, v in pairs(Config.Jobs) do jobroles[tostring(k)] = 0 end
-	exports['qb-target']:AddBoxZone("JimBank", vector3(251.75, 222.17, 106.2), 0.6, 2.0, { name="JimBank", heading = 340.0, debugPoly=false, minZ = 105.75, maxZ = 107.29, }, 
+	--exports['qb-target']:AddBoxZone("JimBank", Config.CashInLocation, 0.6, 2.0, { name="JimBank", heading = 340.0, debugPoly=Config.Debug, minZ = 105.75, maxZ = 107.29, }, 
+	exports['qb-target']:AddCircleZone("JimBank", vector3(Config.CashInLocation.x, Config.CashInLocation.y, Config.CashInLocation.z), 2.0, { name="JimBank", debugPoly=Config.Debug, useZ=true, }, 
 		{ options = { { event = "jim-payments:Tickets:Menu", icon = "fas fa-receipt", label = "Cash in Receipts", job = jobroles } }, distance = 2.0 })
+	if Config.Peds then
+		local i = math.random(1, #Config.PedPool)
+		RequestModel(Config.PedPool[i]) while not HasModelLoaded(Config.PedPool[i]) do Wait(0) end
+		if BankPed == nil then BankPed = CreatePed(0, Config.PedPool[i], Config.CashInLocation, Config.CashInLocation[4], false, false) end
+		if Config.Debug then print("Ped Created for Ticket Trade") end
+	end
 end)

 RegisterNetEvent('jim-payments:client:Charge', function(data)
@@ -36,22 +43,22 @@ RegisterNetEvent('jim-payments:client:Charge', function(data)
 		end
 		if data.img == nil then img = "" else img = data.img end
 		if nearbyList[#nearbyList] == nil then TriggerEvent("QBCore:Notify", "No one near by to charge", "error") return end
-		local dialog = exports['qb-input']:ShowInput({ header = img..PlayerJob.label.." Cash Register", submitText = "Send",
-		inputs = {
-				{ text = " ", name = "citizen", type = "select", options = nearbyList },                
-				{ type = 'radio', name = 'billtype', text = 'Payment Type', options = { { value = "cash", text = "Cash" }, { value = "card", text = "Card" } } }, 
-				{ type = 'number', isRequired = true, name = 'price', text = '💵  Amount to Charge' },}
-		})
+		local newinputs = {}
+		if Config.List then newinputs[#newinputs+1] = { text = " ", name = "citizen", type = "select", options = nearbyList } end
+		if not Config.List then newinputs[#newinputs+1] = { type = 'text', isRequired = true, name = 'citizen', text = '# Customer ID #' } end
+		newinputs[#newinputs+1] = { type = 'radio', name = 'billtype', text = 'Payment Type', options = { { value = "cash", text = "Cash" }, { value = "bank", text = "Card" } } }
+		newinputs[#newinputs+1] = { type = 'number', isRequired = true, name = 'price', text = '💵  Amount to Charge' }
+		local dialog = exports['qb-input']:ShowInput({ header = img..PlayerJob.label.." Cash Register", submitText = "Send", inputs = newinputs})
 		if dialog then
 			if not dialog.citizen or not dialog.price then return end
-			TriggerServerEvent('jim-payments:server:Charge', dialog.citizen, dialog.price, dialog.billtype)
+			TriggerServerEvent('jim-payments:server:Charge', dialog.citizen, dialog.price, dialog.billtype, data.img)
 		end
 	end)
 end)

 RegisterNetEvent('jim-payments:Tickets:Menu', function()
 	local amount = nil
-	while amount == nil do QBCore.Functions.TriggerCallback('jim-payments:Ticket:Count', function(cb) amount = cb end) Citizen.Wait(1) end
+	local p = promise.new() QBCore.Functions.TriggerCallback('jim-payments:Ticket:Count', function(cb) p:resolve(cb) end) amount = Citizen.Await(p)
 	for k, v in pairs(Config.Jobs) do if k ~= PlayerJob.name then 
 		else exports['qb-menu']:openMenu({
 			{ isMenuHeader = true, header = "🧾 "..PlayerJob.label.." Receipts 🧾", txt = "Do you want trade your receipts for payment?" },
@@ -62,13 +69,18 @@ RegisterNetEvent('jim-payments:Tickets:Menu', function()
 	end
 end)

-RegisterNetEvent("jim-payments:client:PayPopup", function(amount, biller, billtype)
+RegisterNetEvent("jim-payments:client:PayPopup", function(amount, biller, billtype, img, billerjob)
+	if img == nil then img = "" end
 	exports['qb-menu']:openMenu({
-		{ isMenuHeader = true, header = "🧾 "..PlayerJob.label.." Payment 🧾", txt = "Do you want accept the payment?" },
+		{ isMenuHeader = true, header = img.."🧾 "..billerjob.." Payment 🧾", txt = "Do you want accept the payment?" },
 		{ isMenuHeader = true, header = "", txt = billtype:gsub("^%l", string.upper).." Payment: $"..amount },
 		{ header = "✅ Yes", txt = "", params = { isServer = true, event = "jim-payments:server:PayPopup", args = { accept = true, amount = amount, biller = biller, billtype = billtype } } },
 		{ header = "❌ No", txt = "", params = { isServer = true, event = "jim-payments:server:PayPopup", args = { accept = false, amount = amount, biller = biller, billtype = billtype } } }, })
 end)

 RegisterNetEvent('jim-payments:Tickets:Sell:yes', function() TriggerServerEvent('jim-payments:Tickets:Sell') end)
-RegisterNetEvent('jim-payments:Tickets:Sell:no', function() exports['qb-menu']:closeMenu() end)
+RegisterNetEvent('jim-payments:Tickets:Sell:no', function() exports['qb-menu']:closeMenu() end)
+
+AddEventHandler('onResourceStop', function(resource) 
+	if resource == GetCurrentResourceName() then exports['qb-target']:RemoveZone("JimBank") DeletePed(BankPed) end 
+end)
--- a/config.lua
+++ b/config.lua
@@ -1,4 +1,4 @@
-print("Jim-Payments v2.1 - Payments Script by Jimathy")
+print("Jim-Payments v2.4 - Payments Script by Jimathy")

 -- If you need support I now have a discord available, it helps me keep track of issues and give better support.

@@ -6,10 +6,35 @@ print("Jim-Payments v2.1 - Payments Script by Jimathy")

 Config = {}

-Config.TicketSystem = true -- Enable this if you want to use the ticket system
+Config.Debug = false

+Config.Manage = true -- "true" if using qb-management
+					 -- "false" if using qb-bossmenu
+					
+Config.TicketSystem = true -- Enable this if you want to use the ticket system false
+
+Config.List = true -- "true" to use nearby player list feature in the cash registers, "false" for manual id entry
 Config.PaymentRadius = 30 -- This is how far the playerlist will check for nearby players (based on the person charging)

+Config.Peds = true -- "true" to enable peds spawning in banks
+Config.PedPool = {
+	[1] = `IG_Bankman`,
+	[2] = `U_M_M_BankMan`,
+	[3] = `S_F_M_Shop_HIGH`,
+	[4] = `S_M_M_HighSec_02`,
+	[5] = `S_M_M_HighSec_03`,
+	[6] = `S_M_M_HighSec_04`,
+	[7] = `A_F_Y_Business_01`,
+	[8] = `A_F_Y_Business_02`,
+	[9] = `A_F_Y_Business_03`,
+	[10] = `A_F_Y_Business_04`,
+	[11] = `A_M_M_Business_01`,
+	[12] = `A_M_Y_Business_02`,
+	[13] = `A_M_Y_Business_03`,
+	[14] = `U_F_M_CasinoShop_01`,
+}
+
+Config.Gabz = false -- "true" to enable Gabz Banking locations
 Config.useATM = true -- Enable this to use my ATM's
 Config.useBanks = true -- Enable this to use my banking stuff
 Config.BankBlips = true -- Enable this if you disabled qb-banking and need bank locations
@@ -18,17 +43,171 @@ Config.ATMBlips = false -- Enable this if you are a pyscho and need every ATM to
 Config.PhoneBank = true -- Set this to false to use the popup payment system FOR CARD/BANK PAYMENTS instead of using phone invoices
 						-- This doesn't affect Cash payments as they by default use confirmation now
 						-- This is helpful for phones that don't support invoices well
-						
+
+Config.Commission = false -- Set this to true to enable Commissions and give the person charging a percentage of the total
+Config.CommissionAll = false -- Set this to true to give commission to workers clocked in
+Config.CommissionDouble = false -- Set this to true if you want the person charging to get double Commission
+Config.CommissionLimit = false -- If true, this limits the Commission to only be given if over the "MinAmountForTicket". If false, Commission will be given for any amount
+
 -- MinAmountforTicket should be your cheapest item
 -- PayPerTicket should never be higher than MinAmountforTicket
+-- Commission is a percentage eg "0.10" becomes 10%
+
+Config.CashInLocation = vector4(252.23, 223.11, 106.29, 159.2) -- Default Third Window along in Pacific Bank
+if Config.Gabz then Config.CashInLocation = vector3(269.28, 217.24, 106.28, 69.0) end	-- Middle along in Pacific Bank (Gabz)
+
 Config.Jobs = {
-	['beanmachine'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
-	['burgershot'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
-	['catcafe'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
-	['henhouse'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
-	['pizzathis'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
-	['popsdiner'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
-	['tequilala'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
-	['vanilla'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
-	['mechanic'] = { MinAmountforTicket = 1000, PayPerTicket = 500 },
+	['beanmachine'] = { MinAmountforTicket = 50, PayPerTicket = 50, Commission = 0.10, },
+	['burgershot'] = { MinAmountforTicket = 50, PayPerTicket = 50 , Commission = 0.10,},
+	['catcafe'] = { MinAmountforTicket = 50, PayPerTicket = 50, Commission = 0.10, },
+	['henhouse'] = { MinAmountforTicket = 50, PayPerTicket = 50, Commission = 0.10, },
+	['pizzathis'] = { MinAmountforTicket = 50, PayPerTicket = 50, Commission = 0.10, },
+	['popsdiner'] = { MinAmountforTicket = 50, PayPerTicket = 50, Commission = 0.10, },
+	['tequilala'] = { MinAmountforTicket = 50, PayPerTicket = 50, Commission = 0.10, },
+	['vanilla'] = { MinAmountforTicket = 50, PayPerTicket = 50, Commission = 0.10, },
+	['mechanic'] = { MinAmountforTicket = 1000, PayPerTicket = 500, Commission = 0.10, },
 }
+
+Config.ATMModels = {"prop_atm_01", "prop_atm_02", "prop_atm_03", "prop_fleeca_atm" }
+
+Config.GabzATMLocations = {
+--PACIFIC BANK 8 ATMS (GABZ)
+	vector3(239.02, 212.37, 106.28),
+	vector3(239.46, 213.6, 106.28),
+	vector3(239.9, 214.82, 106.28),
+	vector3(240.35, 216.03, 106.28),
+	vector3(241.42, 218.96, 106.28),
+	vector3(241.86, 220.16, 106.28),
+	vector3(242.3, 221.41, 106.28),
+	vector3(242.76, 222.63, 106.28),
+}
+
+Config.VanATMLocations = {
+--PACIFIC BANK 10 ATMS
+	vector3(265.9, 213.86, 106.28),
+	vector3(265.56, 212.98, 106.28),
+	vector3(265.19, 211.91, 106.28),
+	vector3(264.86, 211.03, 106.28),
+	vector3(264.52, 210.06, 106.28),
+	vector3(236.64, 219.72, 106.29),
+	vector3(237.04, 218.72, 106.29),
+	vector3(237.5, 217.87, 106.29),
+	vector3(237.93, 216.94, 106.29),
+	vector3(238.36, 216.03, 106.29),
+}
+
+--QB-Target doesn't seem to like ALL ATM Props so need to manually add locations
+Config.WallATMLocations = {
+	vector3(-386.54, 6046.29, 31.5),
+	vector3(-282.82, 6226.24, 31.49),
+	vector3(-132.74, 6366.79, 31.48),
+	vector3(-95.76, 6457.41, 31.46),
+	vector3(-97.52, 6455.65, 31.47),
+	vector3(155.95, 6642.99, 31.6),
+	vector3(173.92, 6638.16, 31.57),
+	vector3(2558.65, 350.92, 108.62),
+	vector3(1077.78, -776.64, 58.35),
+	vector3(1138.14, -468.88, 66.73),
+	vector3(1166.93, -455.96, 66.81),
+	vector3(285.37, 143.07, 104.17),
+	vector3(-165.43, 234.81, 94.92),
+	vector3(-165.4, 232.73, 94.92),
+	vector3(-1410.41, -98.76, 52.43),
+	vector3(-1409.85, -100.51, 52.38),
+	vector3(-1206.0, -324.94, 37.86),
+	vector3(-1205.23, -326.55, 37.86),
+	vector3(-2072.28, -317.27, 13.32),
+	vector3(-2974.7, 380.15, 15.0),
+	vector3(-2959.01, 487.45, 15.46),
+	vector3(-2956.87, 487.36, 15.46),
+	vector3(-3043.98, 594.32, 7.74),
+	vector3(-3241.35, 997.74, 12.55),
+	vector3(-1305.59, -706.64, 25.32),
+	vector3(-537.85, -854.69, 29.28),
+	vector3(-709.98, -818.71, 23.73),
+	vector3(-712.87, -818.71, 23.73),
+	vector3(-526.71, -1223.18, 18.45),
+	vector3(-256.47, -715.94, 33.55),
+	vector3(-259.13, -723.29, 33.54),
+	vector3(-203.82, -861.3, 30.27),
+	vector3(111.38, -774.96, 31.44),
+	vector3(114.56, -776.13, 31.42),
+	vector3(112.46, -819.65, 31.34),
+	vector3(118.93, -883.68, 31.12),
+	vector3(-846.97, -340.29, 38.68),
+	vector3(-846.41, -341.41, 38.68),
+	vector3(-262.21, -2012.17, 30.15),
+	vector3(-273.23, -2024.32, 30.15),
+	vector3(24.46, -945.94, 29.36),
+	vector3(-254.48, -692.74, 33.61),
+	vector3(-1569.95, -546.94, 34.96),
+	vector3(-1570.91, -547.63, 34.96),
+	vector3(289.14, -1282.29, 29.6),
+	vector3(289.18, -1256.84, 29.44),
+	vector3(296.04, -896.22, 29.24),
+	vector3(296.74, -894.26, 29.24),
+	vector3(-301.63, -829.73, 32.43),
+	vector3(-303.23, -829.44, 32.43),
+	vector3(5.27, -919.87, 29.56),
+	vector3(-1200.61, -885.62, 13.26),
+}
+
+Config.VanBankLocations = {
+	["legion"] = {
+		vector4(149.5, -1042.08, 29.37, 342.74), -- Legion Fleeca
+	},
+	["hawick"] = {
+		vector4(313.81, -280.43, 54.16, 342.29), -- Hawick Fleeca
+	},
+	["vinewood"] = {
+		vector4(-351.4, -51.24, 49.04, 338.4), -- Vinewood Fleeca
+	},
+	["delperro"] = {
+		vector4(-1212.11, -332.01, 37.78, 25.33), -- Del Perro Fleeca
+	},
+	["route1"] = {
+		vector4(-2961.17, 482.9, 15.7, 84.68), -- Route 1 Fleeca
+	},
+	["route68"] = {
+		vector4(1175.03, 2708.2, 38.09, 180.0), -- Route 68 Fleeca
+	},
+	["paleto"] = {
+		vector4(-111.22, 6470.03, 31.63, 133.86), -- Paleto Bank
+	},
+	["pacific"] = {
+		vector4(243.58, 226.25, 106.29, 169.06), -- Pacific Bank Window 1	
+		vector4(247.08, 224.98, 106.29, 157.75), -- Pacific Bank Window 2
+	},
+}
+Config.GabzBankLocations = {
+	["legion"] = {
+		vector4(149.5, -1042.08, 29.37, 342.74), -- Legion Fleeca
+	},
+	["hawick"] = {
+		vector4(313.81, -280.43, 54.16, 342.29), -- Hawick Fleeca
+	},
+	["vinewood"] = {
+		vector4(-351.4, -51.24, 49.04, 338.4), -- Vinewood Fleeca
+	},
+	["delperro"] = {
+		vector4(-1212.11, -332.01, 37.78, 25.33), -- Del Perro Fleeca
+	},
+	["route1"] = {
+		vector4(-2961.17, 482.9, 15.7, 84.68), -- Route 1 Fleeca
+	},
+	["route68"] = {
+		vector4(1175.03, 2708.2, 38.09, 180.0), -- Route 68 Fleeca
+	},
+	["paleto"] = {
+		vector4(-110.72, 6469.82, 31.63, 222.94), -- Paleto Bank (GABZ) - 1
+		vector4(-108.98, 6471.56, 31.63, 222.92), -- Paleto Bank (GABZ) - 2
+	},
+	["pacific"] = {
+		vector4(258.55, 227.63, 106.28, 160.96), -- Pacficic Gabz 1+2
+		vector4(263.21, 225.93, 106.28, 158.25), -- Pacficic Gabz 3+4
+		vector4(267.95, 224.24, 106.28, 158.5), -- Pacficic Gabz 5+6
+		vector4(263.71, 212.63, 106.28, 337.53), -- Pacficic Gabz 7+8
+		vector4(259.02, 214.32, 106.28, 337.82), -- Pacficic Gabz 9+10
+		vector4(254.27, 216.06, 106.28, 336.37), -- Pacficic Gabz 11+12
+	}
+}
--- a/fxmanifest.lua
+++ b/fxmanifest.lua
@@ -1,13 +1,13 @@
 name "Jim-Payments"
 author "Jimathy"
-version "v2"
+version "v2.4"
 description "Payment Script By Jimathy"
 fx_version "cerulean"
 game "gta5"

 dependencies {
 	'qb-input',
-	'qb-target'
+	'qb-target',
 }

 client_scripts {
--- a/server.lua
+++ b/server.lua
@@ -13,18 +13,46 @@ end

 --QBCore.Commands.Add("cashregister", "Use mobile cash register", {}, false, function(source) TriggerClientEvent("jim-payments:client:Charge", source, true) end)

-RegisterServerEvent('jim-payments:Tickets:Give', function(amount, job)
-	if Config.TicketSystem then
+RegisterServerEvent('jim-payments:Tickets:Give', function(data, biller)
+	--Find the biller from their citizenid
+	if biller == nil then
 		for k, v in pairs(QBCore.Functions.GetPlayers()) do
-			local Player = QBCore.Functions.GetPlayer(v)
-			if Player ~= nil then
-				if Player.PlayerData.job.name == job and Player.PlayerData.job.onduty then
-					if amount >= Config.Jobs[job].MinAmountforTicket then
+		local Player = QBCore.Functions.GetPlayer(v)
+			if Player.PlayerData.citizenid == data.senderCitizenId then	biller = Player	end
+		end
+	end
+	-- If ticket system enabled, do this
+	if Config.TicketSystem then
+		if data.amount >= Config.Jobs[data.society].MinAmountforTicket then
+			for k, v in pairs(QBCore.Functions.GetPlayers()) do
+				local Player = QBCore.Functions.GetPlayer(v)
+				if Player ~= nil then
+					if Player.PlayerData.job.name == data.society and Player.PlayerData.job.onduty then
 						Player.Functions.AddItem('payticket', 1, false, {["quality"] = nil})
 						TriggerClientEvent('QBCore:Notify', Player.PlayerData.source, 'Receipt received', 'success')
 						TriggerClientEvent('inventory:client:ItemBox', Player.PlayerData.source, QBCore.Shared.Items['payticket'], "add", 1) 
-					elseif amount < Config.Jobs[job].MinAmountforTicket then
-						TriggerClientEvent("QBCore:Notify", Player.PlayerData.source, "Amount too low, didn't receive a receipt", "error")
+					end
+				end
+			end
+		end
+	end
+	-- Commission section, does each config option separately
+	local comm = tonumber(Config.Jobs[data.society].Commission)
+	if Config.Commission and comm ~= 0 then
+		if Config.CommissionLimit and data.amount < Config.Jobs[data.society].MinAmountforTicket then return end
+		if Config.CommissionDouble then	
+			biller.Functions.AddMoney("bank", math.floor(tonumber(data.amount) * (comm *2)))
+			TriggerClientEvent("QBCore:Notify", biller.PlayerData.source, "Recieved $"..math.floor(tonumber(data.amount) * (comm *2)).." in Commission", "success")
+		else biller.Functions.AddMoney("bank",  math.floor(tonumber(data.amount) *comm))
+			TriggerClientEvent("QBCore:Notify", biller.PlayerData.source, "Recieved $"..math.floor(tonumber(data.amount) * comm).." in Commission", "success")
+		end
+		if Config.CommissionAll then
+			for k, v in pairs(QBCore.Functions.GetPlayers()) do
+				local Player = QBCore.Functions.GetPlayer(v)
+				if Player ~= nil and Player ~= biller then
+					if Player.PlayerData.job.name == data.society and Player.PlayerData.job.onduty then
+						Player.Functions.AddMoney("bank",  math.floor(tonumber(data.amount) * comm))
+						TriggerClientEvent("QBCore:Notify", Player.PlayerData.source, "Recieved $"..math.floor(tonumber(data.amount) * comm).." in Commission", "success")
 					end
 				end
 			end
@@ -51,22 +79,23 @@ QBCore.Functions.CreateCallback('jim-payments:Ticket:Count', function(source, cb
 	cb(amount) 
 end)

-RegisterServerEvent("jim-payments:server:Charge", function(citizen, price, billtype)
+RegisterServerEvent("jim-payments:server:Charge", function(citizen, price, billtype, img)
 	local src = source
    local biller = QBCore.Functions.GetPlayer(src)
    local billed = QBCore.Functions.GetPlayer(tonumber(citizen))
    local amount = tonumber(price)
+	local balance = billed.Functions.GetMoney(billtype)
 	if amount and amount > 0 then
-		if billtype == "cash" then balance = billed.Functions.GetMoney(billtype)
-			if balance >= amount then
-				TriggerClientEvent("jim-payments:client:PayPopup", billed.PlayerData.source, amount, src, billtype)
-			elseif balance < amount then
-				TriggerClientEvent("QBCore:Notify", src, "Customer doesn't have enough cash to pay", "error")
-				TriggerClientEvent("QBCore:Notify", tonumber(citizen), "You don't have enough cash to pay", "error")
-			end
-		elseif billtype == "card" then
+		if balance < amount then
+			TriggerClientEvent("QBCore:Notify", src, "Customer doesn't have enough cash to pay", "error")
+			TriggerClientEvent("QBCore:Notify", tonumber(citizen), "You don't have enough cash to pay", "error")
+			return
+		end
+		if billtype == "cash" then 
+			TriggerClientEvent("jim-payments:client:PayPopup", billed.PlayerData.source, amount, src, billtype, img, biller.PlayerData.job.label)
+		elseif billtype == "bank" then
 			if Config.PhoneBank == false then
-				TriggerClientEvent("jim-payments:client:PayPopup", billed.PlayerData.source, amount, src, billtype)
+				TriggerClientEvent("jim-payments:client:PayPopup", billed.PlayerData.source, amount, src, billtype, img, biller.PlayerData.job.label)
 			else
 				MySQL.Async.insert(
 					'INSERT INTO phone_invoices (citizenid, amount, society, sender, sendercitizenid) VALUES (?, ?, ?, ?, ?)',
@@ -83,9 +112,13 @@ RegisterServerEvent("jim-payments:server:PayPopup", function(data)
 	local src = source
    local billed = QBCore.Functions.GetPlayer(src)
    local biller = QBCore.Functions.GetPlayer(tonumber(data.biller))
+	local newdata = { senderCitizenId = biller.PlayerData.citizenid, society = biller.PlayerData.job.name, amount = data.amount }
 	if data.accept == true then
-		billed.Functions.RemoveMoney(tostring(data.billtype), data.amount) TriggerEvent("qb-bossmenu:server:addAccountMoney", tostring(biller.PlayerData.job.name), data.amount)
-		TriggerEvent('jim-payments:Tickets:Give', data.amount, tostring(billed.PlayerData.job.name))
+		billed.Functions.RemoveMoney(tostring(data.billtype), data.amount)
+		if Config.Manage then exports["qb-management"]:AddMoney(tostring(biller.PlayerData.job.name), data.amount)
+		else TriggerEvent("qb-bossmenu:server:addAccountMoney", tostring(biller.PlayerData.job.name), data.amount) end
+		TriggerEvent('jim-payments:Tickets:Give', newdata, biller)
+		TriggerClientEvent("QBCore:Notify", data.biller, billed.PlayerData.charinfo.firstname.." accepted the payment", "success")
 	elseif data.accept == false then
 		TriggerClientEvent("QBCore:Notify", src, "You declined the payment")
 		TriggerClientEvent("QBCore:Notify", data.biller, billed.PlayerData.charinfo.firstname.." declined the payment", "error")
Author	SHA1	Message	Date
jimathy	abe360bc6b	Ped Support and better Gabz Support in config	2022-04-20 13:52:32 +01:00
jimathy	3c3fe054e0	Merge pull request #5 from jimathy/jimathy-patch-2 Debug mode + Custom Ticket Cashin + Gabz Locations	2022-04-19 21:32:35 +01:00
jimathy	4da8c039e7	Disable debug mode	2022-04-19 21:32:12 +01:00
jimathy	a9f7ac5663	Default setting to vanilla location	2022-04-19 21:30:08 +01:00
jimathy	712096887b	Debug mode + Custom Ticket Cashin + Gabz Locations	2022-04-19 21:26:43 +01:00
jimathy	892acf1283	Add toggles for bossmenu/management + nearbylist	2022-04-15 18:25:27 +01:00
jimathy	13d83a066a	Fix job label on payment popup	2022-04-12 21:10:48 +01:00
jimathy	88765357b3	Fix job label on payment popup	2022-04-12 21:09:44 +01:00
jimathy	f9029f0951	Commission update	2022-04-11 18:59:47 +01:00
jimathy	65f51520fb	Update Readme with new phone event and info	2022-04-11 18:58:55 +01:00
jimathy	7e92b852cf	fix bank popups and popup job tickets	2022-04-06 22:30:26 +01:00
jimathy	a63b40c11f	fix pay popups for shops with no logo	2022-04-06 22:18:38 +01:00
jimathy	644294546e	qb-management export update	2022-04-03 20:52:10 +01:00
jimathy	4dbe600680	qb-management export update	2022-04-03 20:51:34 +01:00
jimathy	9d5086e5d5	qb-management export update	2022-04-03 20:41:07 +01:00
jimathy	b06cb05266	Merge pull request #3 from stacheboi/main Fix for Player Receiving Cash From Self	2022-03-26 17:50:06 +00:00
jimathy	f16a0b0d1f	Removed loops, it was being too strict	2022-03-17 10:57:14 +00:00
jimathy	48003e09a6	Fix for everyone being able to access boss account	2022-03-17 10:43:04 +00:00
stacheboi	95459f63a8	Fix for Player Receiving Cash From Self When you give someone cash it shows they received money from themself. This show show the sending players name instead.	2022-03-16 21:17:10 -04:00
jimathy	0065af7c9d	Notify on accepted payment	2022-03-15 21:32:49 +00:00
jimathy	74990226a9	fix for fix. I need a rest	2022-03-13 13:15:57 +00:00
jimathy	2e5bcc4d86	Fix for bank popup payments	2022-03-13 13:03:09 +00:00
jimathy	185c641f60	fix for tickets with new popup	2022-03-12 12:56:30 +00:00