Release Notifier Push

This reverts commit f08638812c.

.github/workflows/notify-release.yml

@@ -0,0 +1,71 @@
+name: Discord Release Notifier
+
+on:
+  # Manual or UI-published releases
+  release:
+    types: [published]
+
+  # Releases created by your tag-driven workflow
+  workflow_run:
+    workflows: ["Package & Release"]  # must match the 'name:' in release.yml
+    types: [completed]
+
+permissions:
+  contents: read
+
+jobs:
+  # 1) Handle manual / UI / non-workflow-created releases
+  notify-from-release:
+    if: github.event_name == 'release' && github.event.action == 'published'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Send release payload to Discord Bot
+        env:
+          URL: http://${{ secrets.DISCORDBOT }}:3000/github-releases
+        run: |
+          curl -sS -X POST "$URL" \
+            -H 'Content-Type: application/json' \
+            --data-binary "@$GITHUB_EVENT_PATH"
+
+  # 2) Handle releases created by your 'Package & Release' workflow
+  #    (which won’t trigger `on: release` when using GITHUB_TOKEN)
+  notify-from-workflow-run:
+    if: >
+      github.event_name == 'workflow_run' &&
+      github.event.workflow_run.conclusion == 'success'
+    runs-on: ubuntu-latest
+    steps:
+      - name: Install jq
+        run: sudo apt-get update && sudo apt-get install -y jq
+
+      - name: Fetch release JSON by tag
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          set -euo pipefail
+          OWNER="${GITHUB_REPOSITORY%/*}"
+          REPO="${GITHUB_REPOSITORY#*/}"
+          TAG="${{ github.event.workflow_run.head_branch }}"
+          # head_branch is the tag name for a tag push workflow_run
+          curl -fsSL -H "Authorization: Bearer $GH_TOKEN" \
+               -H "Accept: application/vnd.github+json" \
+               "https://api.github.com/repos/$OWNER/$REPO/releases/tags/$TAG" \
+               > release.json
+
+      - name: Wrap as 'release' event payload & notify bot
+        env:
+          URL: http://${{ secrets.DISCORDBOT }}:3000/github-releases
+        run: |
+          set -euo pipefail
+          jq -n --slurpfile rel release.json \
+                --arg repo "$GITHUB_REPOSITORY" \
+                --arg repo_url "https://github.com/$GITHUB_REPOSITORY" \
+                --arg action "published" '
+            { action: $action,
+              repository: { full_name: $repo, html_url: $repo_url },
+              release: $rel[0],
+              sender: { login: "github-actions[bot]" } }' > payload.json
+
+          curl -sS -X POST "$URL" \
+            -H 'Content-Type: application/json' \
+            --data-binary "@payload.json"

fxmanifest.lua

@@ -1,6 +1,6 @@
 name "Jim_Bridge"
 author "Jimathy"
-version "2.1.01"
+version "2.1.02"
 description "Framework Bridge By Jimathy"
 fx_version "cerulean"
 rdr3_warning 'I acknowledge that this is a prerelease build of RedM, and I am aware my resources *will* become incompatible once RedM ships.'

shared/_authToken.lua

@@ -124,7 +124,6 @@ end
 
 function distExploitCheck(table, src)
     if forceDisableExplotProtection == true then return true end
-
     if not table then
         print("^1Error^7: ^1This wasn^7'^1t reigstered correctly or this is an exploit attempt^1")
         return false
@@ -135,7 +134,7 @@ function distExploitCheck(table, src)
     local allow = false
 
     for i = 1, #table do
-        if #(table[i].xyz  - srcCoords) <= 10 then
+        if #(table[i].xy  - srcCoords.xy) <= 10 then
             return true
         else
             allow = false
@@ -143,7 +142,7 @@ function distExploitCheck(table, src)
     end
 
     if not allow then
-        print(src and ("^1Src ^3"..src.." ").."^1Tried to open a registered shop/stash from over the distance limit^7")
+        print(src and ("^1Src ^3"..src.." ") or "", "^1Tried to open a registered shop/stash from over the distance limit^7")
         return false
     end
 

shared/_loaders.lua

@@ -27,6 +27,132 @@ local function _debouncedRun(func)
     end)
 end
 
+local frameworkLoadFunc = {
+    {   framework = Exports.QBXExport,
+        onPlayerLoaded =
+            function(func)
+                RegisterNetEvent('QBCore:Client:OnPlayerLoaded', func)
+            end,
+        onPlayerUnload =
+            function(func)
+                RegisterNetEvent('QBCore:Client:OnPlayerUnload', func)
+            end,
+        waitforLogin =
+            function(timeout)
+                local startTime = GetGameTimer()
+                while not LocalPlayer.state.isLoggedIn and (GetGameTimer() - startTime) < timeout do
+                    Wait(100)
+                end
+                return LocalPlayer.state.isLoggedIn
+            end,
+    },
+
+    {   framework = Exports.QBExport,
+        onPlayerLoaded =
+            function(func)
+                RegisterNetEvent('QBCore:Client:OnPlayerLoaded', func)
+            end,
+        onPlayerUnload =
+            function(func)
+                RegisterNetEvent('QBCore:Client:OnPlayerUnload', func)
+            end,
+        waitforLogin =
+            function(timeout)
+                local startTime = GetGameTimer()
+                while not LocalPlayer.state.isLoggedIn and (GetGameTimer() - startTime) < timeout do
+                    Wait(100)
+                end
+                return LocalPlayer.state.isLoggedIn
+            end,
+    },
+
+    {   framework = Exports.ESXExport,
+        onPlayerLoaded =
+            function(func)
+                RegisterNetEvent("esx:playerLoaded", function()
+                    -- make sure shared has loaded (because sql)
+                    if waitForSharedLoad() then func() end
+                end)
+            end,
+        onPlayerUnload =
+            function(func)
+                RegisterNetEvent("esx:onPlayerLogout", func)
+            end,
+        waitforLogin =
+            function(timeout)
+                local startTime = GetGameTimer()
+                while (GetGameTimer() - startTime) < timeout do
+                    local playerData = ESX.GetPlayerData()
+                    if playerData and playerData.job then
+                        return true
+                    end
+                    Wait(100)
+                end
+            end,
+    },
+
+    {   framework = Exports.OXCoreExport,
+        onPlayerLoaded =
+            function(func)
+                RegisterNetEvent('ox:playerLoaded', func)
+            end,
+        onPlayerUnload =
+            function(func)
+                RegisterNetEvent('ox:playerLogout', func)
+            end,
+        waitforLogin =
+            function(timeout)
+                if OxPlayer["stateId"] then
+                    return true
+                end
+                while not OxPlayer["stateId"] do
+                    Wait(1000)
+                    if OxPlayer.get["stateId"] then
+                        return true
+                    end
+                end
+            end,
+    },
+
+    {   framework = Exports.RSGExport,
+        onPlayerLoaded =
+            function(func)
+                RegisterNetEvent('RSGCore:Client:OnPlayerLoaded', func)
+            end,
+        onPlayerUnload =
+            function(func)
+                RegisterNetEvent('RSGCore:Client:OnPlayerUnload', func)
+            end,
+        waitforLogin =
+            function(timeout)
+                local startTime = GetGameTimer()
+                while not LocalPlayer.state.isLoggedIn and (GetGameTimer() - startTime) < timeout do
+                    Wait(100)
+                end
+                return LocalPlayer.state.isLoggedIn
+            end,
+    },
+
+    {   framework = Exports.VorpExport,
+        onPlayerLoaded =
+            function(func)
+                RegisterNetEvent('vorp_core:Client:OnPlayerSpawned', func)
+            end,
+        onPlayerUnload =
+            function(func)
+                --??
+            end,
+        waitforLogin =
+            function(timeout)
+                local startTime = GetGameTimer()
+                while not LocalPlayer.state.IsInSession and (GetGameTimer() - startTime) < timeout do
+                    Wait(100)
+                end
+                return LocalPlayer.state.IsInSession
+            end,
+    },
+}
+
 -------------------------------------------------------------
 -- Player Loaded and Unloaded Events
 -------------------------------------------------------------
@@ -44,9 +170,6 @@ end
 --- end, true)
 --- ```
 function onPlayerLoaded(func, onStart)
-    local onPlayerFramework = ""
-    local loaded = false
-
     if onStart then
         onResourceStart(function()
             if not waitForLogin() then return end
@@ -59,34 +182,16 @@ function onPlayerLoaded(func, onStart)
         _debouncedRun(func)
     end
 
-    if isStarted(QBExport) or isStarted(QBXExport) then
-        onPlayerFramework = QBExport
-        RegisterNetEvent('QBCore:Client:OnPlayerLoaded', handler)
-
-    elseif isStarted(ESXExport) then
-        onPlayerFramework = ESXExport
-        RegisterNetEvent('esx:playerLoaded', function()
-            if waitForSharedLoad() then handler() end
-        end)
-
-    elseif isStarted(OXCoreExport) then
-        onPlayerFramework = OXCoreExport
-        RegisterNetEvent('ox:playerLoaded', handler)
-
-    elseif isStarted(RSGExport) then
-        onPlayerFramework = RSGExport
-        RegisterNetEvent('RSGCore:Client:OnPlayerLoaded', handler)
-
-    elseif isStarted(VorpExport) then
-        onPlayerFramework = VorpExport
-        RegisterNetEvent('vorp_core:Client:OnPlayerSpawned', handler)
-    end
-
-    if onPlayerFramework ~= "" then
-        debugPrint("^6Bridge^7: ^2Registering ^3onPlayerLoaded^7()^2 with ^3" .. onPlayerFramework .. "^7")
-    else
-        print("^4ERROR^7: No supported core detected for onPlayerLoaded - Check starter.lua")
+    for i = 1, #frameworkLoadFunc do
+        local data = frameworkLoadFunc[i]
+        jsonPrint(data)
+        if isStarted(data.framework) then
+            debugPrint("^6Bridge^7: ^2Registering ^3"..data.framework.." ^5onPlayerLoaded^7()")
+            data.onPlayerLoaded(handler)
+            return
+        end
     end
+    print("^1ERROR^7: ^1No supported core detected for onPlayerLoaded - Check starter.lua^7")
 end
 
 --- Executes a function when the player character is unloaded.
@@ -99,15 +204,15 @@ end
 --- end)
 --- ```
 function onPlayerUnload(func)
-    debugPrint("^6Bridge^7: ^2Registering ^3onPlayerUnload^7()")
-    RegisterNetEvent('QBCore:Client:OnPlayerUnload', function() func() end)
-
-    RegisterNetEvent('ox:playerLogout', function() func() end)
-
-    RegisterNetEvent('RSGCore:Client:OnPlayerUnload', function() func() end)
-
-    RegisterNetEvent('esx:onPlayerLogout', function() func() end)
-
+    for i = 1, #frameworkLoadFunc do
+        local data = frameworkLoadFunc[i]
+        if isStarted(data.framework) then
+            debugPrint("^6Bridge^7: ^2Registering ^3"..data.framework.." ^5onPlayerUnload^7()")
+            data.onPlayerUnload(func)
+            return
+        end
+    end
+    print("^1ERROR^7: ^1No supported core detected for onPlayerUnload - Check starter.lua^7")
 end
 
 -------------------------------------------------------------
@@ -166,51 +271,18 @@ end
 --- @usage
 --- waitForLogin()
 function waitForLogin()
-    local timeout = 10000  -- 10 seconds in milliseconds
-    local startTime = GetGameTimer()
-    local loggedIn = false
-
-    if isStarted(ESXExport) then
-        while (GetGameTimer() - startTime) < timeout do
-            local playerData = ESX.GetPlayerData()
-            if playerData and playerData.job then
-                loggedIn = true
-                break
+    for i = 1, #frameworkLoadFunc do
+        local data = frameworkLoadFunc[i]
+        if isStarted(data.framework) then
+            debugPrint("^6Bridge^7: ^2Waiting for ^3"..data.framework.."^2 player login^7.")
+            local result = data.waitforLogin(10000)
+            if result == true then
+                debugPrint("^6Bridge^7: ^3"..data.framework.."^2 Player Login Detected^7.")
+            else
+                print("^4Error^7: ^2Timeout reached while waiting for player login^7.")
             end
-            Wait(100)
+            return result
         end
-    elseif isStarted(OXCoreExport) then
-        if OxPlayer["stateId"] then
-            loggedIn = true
-        end
-        while not OxPlayer["stateId"] do
-            Wait(1000)
-            debugPrint("Waiting for stateId to class as logged in")
-            if OxPlayer.get["stateId"] then
-                loggedIn = true
-                break
-            end
-        end
-    elseif isStarted(VorpExport) then
-        -- For other frameworks, use LocalPlayer.state.isLoggedIn.
-        while not LocalPlayer.state.IsInSession and (GetGameTimer() - startTime) < timeout do
-            Wait(100)
-        end
-        loggedIn = LocalPlayer.state.IsInSession
-    else
-        -- For other frameworks, use LocalPlayer.state.isLoggedIn.
-        while not LocalPlayer.state.isLoggedIn and (GetGameTimer() - startTime) < timeout do
-            Wait(100)
-        end
-        loggedIn = LocalPlayer.state.isLoggedIn
-    end
-
-    if not loggedIn then
-        print("^4Error^7: ^2Timeout reached while waiting for player login^7.")
-        return false
-    else
-        debugPrint("^6Bridge^7: ^2Player Login Detected^7.")
-        return true
     end
 end
 

shared/itemcontrol.lua

@@ -56,7 +56,7 @@ local InvFunc = {
                 local weight = 0
                 local itemcheck = getPlayerInv(src)
                 for _, v in pairs(itemcheck) do
-                    weight += ((v.weight * v.amount) or 0)
+                    weight += v.weight
                 end
                 return weight
             end,
@@ -88,7 +88,6 @@ local InvFunc = {
                     inventory = items,
                     society = society,
                 })
-                debugPrint("^6Bridge^7: ^2Registering ^5"..OXInv.." ^3Store^7:", name, "^4Label^7: "..label)
             end,
         openStash =
             function(data)
@@ -123,7 +122,6 @@ local InvFunc = {
         registerStash =
             function(name, label, slots, weight, owner, coords)
                 exports[OXInv]:RegisterStash(name, label, slots or 50, weight or 4000000, owner or nil)
-                debugPrint("^6Bridge^7: ^2Registering ^4"..OXInv.." ^3Stash^7:", name, "^4Label^7: "..label)
             end,
     },
 
@@ -322,7 +320,6 @@ local InvFunc = {
         registerStash =
             function(name, label, slots, weight, owner, coords)
                 exports[OrigenInv]:registerStash(name, label, slots or 50, weight or 4000000)
-                debugPrint("^6Bridge^7: ^2Registering ^4"..OrigenInv.." ^3Stash^7:", name, "^4Label^7: "..label)
             end,
     },
 
@@ -344,7 +341,7 @@ local InvFunc = {
                 local count = 0
                 for _, itemData in pairs(invCache) do
                     if itemData and itemData.name == item then
-                        count += (itemData.amount or itemData.count or 1)
+                        count += (itemData.amount or 0)
                     end
                 end
                 return count >= amount, count
@@ -387,7 +384,7 @@ local InvFunc = {
                 if src then
                     grabInv = exports[CodeMInv]:GetInventory(getPlayer(src).citizenId, src)
                 else
-                    grabInv = exports[CodeMInv]:getUserInventory()
+                    grabInv = exports[CodeMInv]:GetClientPlayerInventory()
                 end
                 return grabInv
             end,
@@ -514,7 +511,6 @@ local InvFunc = {
         registerShop =
             function(name, label, items, society)
                 exports[TgiannInv]:RegisterShop(name, items)
-                debugPrint("^6Bridge^7: ^2Registering ^5"..TgiannInv.." ^3Store^7:", name, "^4Label^7: "..label)
             end,
         openStash =
             function(data)
@@ -548,7 +544,6 @@ local InvFunc = {
         registerStash =
             function(name, label, slots, weight, owner, coords)
                 exports[TgiannInv]:RegisterStash(name, label, slots or 50, weight or 4000000)
-                debugPrint("^6Bridge^7: ^2Registering ^4"..TgiannInv.." ^3Stash^7:", name, "^4Label^7: "..label)
             end,
     },
 
@@ -841,7 +836,6 @@ local InvFunc = {
                         items = items,
                         society = society,
                     })
-                    debugPrint("^6Bridge^7: ^2Registering ^5"..QBInv.." ^3Store^7:", name, "^4Label^7: "..label)
                 end
             end,
         openStash =
@@ -1040,7 +1034,6 @@ local InvFunc = {
                         items = items,
                         society = society,
                     })
-                    debugPrint("^6Bridge^7: ^2Registering ^5"..PSInv.." ^3Store^7:", name, "^4Label^7: "..label)
                 end
             end,
         openStash =
@@ -1206,7 +1199,6 @@ local InvFunc = {
                     items = items,
                     society = society,
                 })
-                debugPrint("^6Bridge^7: ^2Registering ^5"..RSGInv.." ^3Store^7:", name, "^4Label^7: "..label)
             end,
         openStash =
             function(data)
@@ -1287,6 +1279,7 @@ end
 function hasItem(items, amount, src)
     local amount = amount and amount or 1
     local grabInv, foundInv = getPlayerInv(src)
+
     if type(items) ~= "table" then items = { [items] = amount and amount or 1, } end
 
     local hasTable = {}
@@ -2357,6 +2350,7 @@ function registerStash(name, label, slots, weight, owner, coords)
         local inv = InvFunc[i]
         if isStarted(inv.invName) then
             inv.registerStash(name, label, slots, weight, owner, coords)
+            debugPrint("^6Bridge^7: ^2Registering ^4"..inv.invName.." ^3Stash^7:", name, "^4Label^7: "..label, coords and "- ^4Coord^7: "..formatCoord(coords) or "NO COORD SET")
             break
         end
     end
@@ -2487,6 +2481,7 @@ function sellMenu(data)
                             sellMenu(origData)
                         end
                         v.sellTable = data.sellTable[k]
+                        v.name = data.name
                         sellMenu(v)
                     end,
                 }
@@ -2522,7 +2517,7 @@ end
 --- ```
 function sellAnim(data, token)
     if not hasItem(data.item, 1) then
-        triggerNotify(nil, Loc[Config.Lan].error["dont_have"].." "..getItemLabel(data.item), "error")
+        triggerNotify(nil, (Loc[Config.Lan].error["dont_have"] or "You don't have any") .." "..getItemLabel(data.item), "error")
         return
     end
 
@@ -2589,8 +2584,8 @@ RegisterNetEvent(getScript()..":Sellitems", function(data, token)
 end)
 
 function registerSellShop(name, coords)
-    if coords and type(coords) == "vector3" then
-        print("Registered Sell Shop "..name.." Correctly")
+    if coords then
+        debugPrint("^6Bridge^7: ^2Registering ^3Sell Store^7: "..name, coords and "- ^4Coord^7: "..formatCoord(coords) or "NO COORD SET")
         sellShopExploitCheck[name] = sellShopExploitCheck[name] or {}
         sellShopExploitCheck[name][#sellShopExploitCheck[name]+1] = coords
     end
@@ -2690,16 +2685,22 @@ end)
 --- registerShop("weaponShop", "Weapon Shop", weaponItems, "society_weapons")
 --- ```
 function registerShop(name, label, items, society, coords)
-    local shopResource = ""
     -- ensure tables exist
     shopExploitCheck = shopExploitCheck or {}
     shopExploitCheck[name] = shopExploitCheck[name] or {}
 
+    if isStarted("jim-shops") then
+        -- Add support for new jim-shops registration export
+        if checkExportExists("jim-shops", "registerShop") then
+            exports["jim-shops"]:registerShop(name, label, items, society, coords)
+        end
+    end
+
     for i = 1, #InvFunc do
         local inv = InvFunc[i]
         if isStarted(inv.invName) then
-            shopResource = inv.invName
             inv.registerShop(name, label, items, society)
+            debugPrint("^6Bridge^7: ^2Registering ^5"..inv.invName.." ^3Store^7:", name, "^4Label^7: "..label, coords and "- ^4Coord^7: "..formatCoord(coords) or "NO COORD SET")
             break
         end
     end
@@ -2710,10 +2711,4 @@ function registerShop(name, label, items, society, coords)
     else
         print("^3Warning^7: ^1Store ^4"..name.." ^1doesn^7'^1t have coords^7, ^1this is exploitable^7, ^1add coords to ^3regiterShop^7()")
     end
-
-    if shopResource ~= "" then
-        debugPrint("^6Bridge^7: ^2Registering ^5"..shopResource.." ^3Store^7:", name, "^4Label^7: "..label)
-    else
-    --    debugPrint("^1ERROR^7: ^1Couldn't find supported inventory to register shop^7:", name)
-    end
 end

shared/jobfunctions.lua

@@ -33,6 +33,7 @@ local bossMenuFunc = {
 
     {   name = "esx_society",
         openBossMenu = function(isGang, group)
+            TriggerServerEvent(getScript()..":registerESXSociety", isGang, group)
             TriggerEvent('esx_society:openBossMenu', group, function() end, { wash = false })
         end,
     },
@@ -60,6 +61,20 @@ function openBossMenu(isGang, group)
     end
 end
 
+-- Register ESX Society account in the server
+RegisterNetEvent(getScript()..":registerESXSociety", function(group)
+    local checkExist = exports.esx_society:GetSociety(group)
+    if checkExist == nil then
+        exports.esx_society:registerSociety(
+            group,
+            Gangs[group] and Gangs[group].label or Jobs[group] and Jobs[group].label,
+            group,
+            group,
+            group,
+            {type = "public"}
+        )
+    end
+end)
 
 -------------------------------------------------------------
 -- Global Duty Status

shared/make/cameras.lua

@@ -71,6 +71,7 @@ function startTempCam(cam, renderTime, loadScene, filter, switchCam)
 		-- if moving from a cached previous cam, or you've sent a camre id for it to switch from, interpolate to it
 		if switchCam or cachePrevCam then
 			SetCamActiveWithInterp(cam, cachePrevCam, renderTime or 1000, 0, 0)
+			SetCamActive(cachePrevCam, false) -- Set previous cam inactive (shouldn't be needed but just in case)
 		else
 			SetCamActive(cam, true)
 		end

shared/make/progressBars.lua

@@ -52,7 +52,7 @@ local progressFunc = {
                     if exports[OXLibExport]:progressBar(options) then
                         return true
                     else
-                        print("^1progressBar was not successful")
+                        return false
                     end
                 end
             end,

shared/playerfunctions.lua

@@ -16,14 +16,18 @@ local hungerThirstFunc = {
         setThirst =
             function(src, thirst)
                 local Player = Core.Functions.GetPlayer(src)
-                Player.Functions.SetMetaData('thirst', thirst)
-                TriggerClientEvent("hud:client:UpdateNeeds", src, Player.PlayerData.metadata.hunger, thirst)
+                local newThirst = Player.PlayerData.metadata.thirst + thirst
+                newThirst = (newThirst >= 100.0 and 100.0) or (newThirst <= 0 and 0) or newThirst
+                Player.Functions.SetMetaData('thirst', newThirst)
+                TriggerClientEvent("hud:client:UpdateNeeds", src, Player.PlayerData.metadata.hunger, newThirst)
             end,
         setHunger =
             function(src, hunger)
                 local Player = Core.Functions.GetPlayer(src)
-                Player.Functions.SetMetaData('hunger', hunger)
-                TriggerClientEvent("hud:client:UpdateNeeds", src, hunger, Player.PlayerData.metadata.thirst)
+                local newHunger = Player.PlayerData.metadata.hunger + hunger
+                newHunger = (newHunger >= 100.0 and 100.0) or (newHunger <= 0 and 0) or newHunger
+                Player.Functions.SetMetaData('hunger', newHunger)
+                TriggerClientEvent("hud:client:UpdateNeeds", src, newHunger, Player.PlayerData.metadata.thirst)
             end,
     },
 
@@ -31,14 +35,18 @@ local hungerThirstFunc = {
         setThirst =
             function(src, thirst)
                 local Player = Core.Functions.GetPlayer(src)
-                Player.Functions.SetMetaData('thirst', thirst)
-                TriggerClientEvent("hud:client:UpdateNeeds", src, Player.PlayerData.metadata.hunger, thirst)
+                local newThirst = Player.PlayerData.metadata.thirst + thirst
+                newThirst = (newThirst >= 100.0 and 100.0) or (newThirst <= 0 and 0) or newThirst
+                Player.Functions.SetMetaData('thirst', newThirst)
+                TriggerClientEvent("hud:client:UpdateNeeds", src, Player.PlayerData.metadata.hunger, newThirst)
             end,
         setHunger =
             function(src, hunger)
                 local Player = Core.Functions.GetPlayer(src)
-                Player.Functions.SetMetaData('hunger', hunger)
-                TriggerClientEvent("hud:client:UpdateNeeds", src, hunger, Player.PlayerData.metadata.thirst)
+                local newHunger = Player.PlayerData.metadata.hunger + hunger
+                newHunger = (newHunger >= 100.0 and 100.0) or (newHunger <= 0 and 0) or newHunger
+                Player.Functions.SetMetaData('hunger', newHunger)
+                TriggerClientEvent("hud:client:UpdateNeeds", src, newHunger, Player.PlayerData.metadata.thirst)
             end,
     },
 
@@ -46,25 +54,29 @@ local hungerThirstFunc = {
         setThirst =
             function(src, thirst)
                 local Player = Core.Functions.GetPlayer(src)
-                Player.Functions.SetMetaData('thirst', thirst)
-                TriggerClientEvent("hud:client:UpdateNeeds", src, Player.PlayerData.metadata.hunger, thirst)
+                local newThirst = Player.PlayerData.metadata.thirst + thirst
+                newThirst = (newThirst >= 100.0 and 100.0) or (newThirst <= 0 and 0) or newThirst
+                Player.Functions.SetMetaData('thirst', newThirst)
+                TriggerClientEvent("hud:client:UpdateNeeds", src, Player.PlayerData.metadata.hunger, newThirst)
             end,
         setHunger =
             function(src, hunger)
                 local Player = Core.Functions.GetPlayer(src)
-                Player.Functions.SetMetaData('hunger', hunger)
-                TriggerClientEvent("hud:client:UpdateNeeds", src, hunger, Player.PlayerData.metadata.thirst)
+                local newHunger = Player.PlayerData.metadata.hunger + hunger
+                newHunger = (newHunger >= 100.0 and 100.0) or (newHunger <= 0 and 0) or newHunger
+                Player.Functions.SetMetaData('hunger', newHunger)
+                TriggerClientEvent("hud:client:UpdateNeeds", src, newHunger, Player.PlayerData.metadata.thirst)
             end,
     },
 
     {   framework = ESXExport,
         setThirst =
             function(src, thirst)
-                TriggerClientEvent('esx_status:add', src, 'thirst', thirst)
+                TriggerClientEvent('esx_status:add', src, 'thirst', tonumber(thirst) * 10000)
             end,
         setHunger =
             function(src, hunger)
-                TriggerClientEvent('esx_status:add', src, 'hunger', hunger)
+                TriggerClientEvent('esx_status:add', src, 'hunger', tonumber(hunger) * 10000)
             end,
     },
 }
@@ -372,19 +384,21 @@ local hasGroupFunc = {
                 local hasJobFlag, duty = false, true
                 local playerInfo = GetPlayer(src)
                 local jobinfo = playerInfo.job or playerInfo.PlayerData.job
-                if jobinfo.name == group then
+                if jobinfo and jobinfo.name == group then
                     hasJobFlag = true
                     duty = jobinfo.onduty
                     if grade and not (grade <= jobinfo.grade.level) then
                         hasJobFlag = false
                     end
+                    return hasJobFlag, duty
                 end
                 local ganginfo = playerInfo.gang or playerInfo.PlayerData.gang
-                if ganginfo.name == group then
+                if ganginfo and ganginfo.name == group then
                     hasJobFlag = true
                     if grade and not (grade <= ganginfo.grade.level) then
                         hasJobFlag = false
                     end
+                    return hasJobFlag, duty
                 end
                 return hasJobFlag, duty
             end,
@@ -396,7 +410,7 @@ local hasGroupFunc = {
                 local hasJobFlag, duty = false, true
                 local playerInfo = GetPlayer(src)
                 local jobinfo = playerInfo.job or playerInfo.PlayerData.job
-                if jobinfo.name == group then
+                if jobinfo and jobinfo.name == group then
                     hasJobFlag = true
                     duty = jobinfo.onduty
                     if grade and not (grade <= jobinfo.grade.level) then
@@ -404,7 +418,7 @@ local hasGroupFunc = {
                     end
                 end
                 local ganginfo = playerInfo.gang or playerInfo.PlayerData.gang
-                if ganginfo.name == group then
+                if ganginfo and ganginfo.name == group then
                     hasJobFlag = true
                     if grade and not (grade <= ganginfo.grade.level) then
                         hasJobFlag = false
@@ -434,26 +448,6 @@ local hasGroupFunc = {
             end,
     },
 
-    {   framework = OXCoreExport,
-        hasGroup =
-            function(group, grade, src)
-                local hasJobFlag, duty = false, true
-                if src then
-                    local chunk = assert(load(LoadResourceFile('ox_core', ('imports/%s.lua'):format('server')), ('@@ox_core/%s'):format(file)))
-                    chunk()
-                    local player = Ox.GetPlayer(src)
-                    for k, v in pairs(player.getGroups()) do
-                        if k == group then hasJobFlag = true end
-                    end
-                end
-                local info = OxPlayer.getGroups()
-                for k, v in pairs(info) do
-                    if k == group then hasJobFlag = true break end
-                end
-                return hasJobFlag, duty
-            end,
-    },
-
     {   framework = ESXExport,
         hasGroup =
             function(group, grade, src)
@@ -479,7 +473,7 @@ local hasGroupFunc = {
                 local hasJobFlag, duty = false, true
                 local playerInfo = GetPlayer(src)
                 local jobinfo = playerInfo.job or playerInfo.PlayerData.job
-                if jobinfo.name == group then
+                if jobinfo and jobinfo.name == group then
                     hasJobFlag = true
                     duty = jobinfo.onduty
                     if grade and not (grade <= jobinfo.grade.level) then
@@ -487,7 +481,7 @@ local hasGroupFunc = {
                     end
                 end
                 local ganginfo = playerInfo.gang or playerInfo.PlayerData.gang
-                if ganginfo.name == group then
+                if ganginfo and ganginfo.name == group then
                     hasJobFlag = true
                     if grade and not (grade <= ganginfo.grade.level) then
                         hasJobFlag = false

shared/societybank.lua

@@ -12,52 +12,6 @@
 ]]
 
 local societyFunc = {
-    {   bankName = "qb-banking",
-        getAccount =
-            function(society)
-                if not exports["qb-banking"]:GetAccount(society) then
-                    if Jobs[society] then
-                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
-                        exports["qb-banking"]:CreateJobAccount(society, 0)
-                        Wait(150)
-                    elseif Gangs[society] then
-                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
-                        exports["qb-banking"]:CreateGangAccount(society, 0)
-                        Wait(150)
-                    end
-                end
-                return exports["qb-banking"]:GetAccountBalance(society)
-            end,
-        chargeSociety =
-            function(society, amount)
-                if not exports["qb-banking"]:GetAccount(society) then
-                    if Jobs[society] then
-                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
-                        exports["qb-banking"]:CreateJobAccount(society, 0) Wait(150) -- make new account if return "null"
-                    elseif Gangs[society] then
-                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
-                        exports["qb-banking"]:CreateGangAccount(society, 0) Wait(150) -- make new account if return "null"
-                    end
-                end
-                exports["qb-banking"]:RemoveMoney(society, amount)
-            end,
-        fundSociety =
-            function(society, amount)
-                if not exports["qb-banking"]:GetAccount(society) then
-                    if Jobs[society] then
-                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
-                        exports["qb-banking"]:CreateJobAccount(society, 0)
-                        Wait(150)
-                    elseif Gangs[society] then
-                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
-                        exports["qb-banking"]:CreateGangAccount(society, 0)
-                        Wait(150)
-                    end
-                end
-                exports["qb-banking"]:AddMoney(society, amount)
-            end,
-    },
-
     {   bankName = "Renewed-Banking",
         getAccount =
             function(society)
@@ -129,6 +83,115 @@ local societyFunc = {
                 end
             end,
     },
+
+    {   bankName = "qb-banking",
+        getAccount =
+            function(society)
+                if not exports["qb-banking"]:GetAccount(society) then
+                    if Jobs[society] then
+                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
+                        exports["qb-banking"]:CreateJobAccount(society, 0)
+                        Wait(150)
+                    elseif Gangs[society] then
+                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
+                        exports["qb-banking"]:CreateGangAccount(society, 0)
+                        Wait(150)
+                    end
+                end
+                return exports["qb-banking"]:GetAccountBalance(society)
+            end,
+        chargeSociety =
+            function(society, amount)
+                if not exports["qb-banking"]:GetAccount(society) then
+                    if Jobs[society] then
+                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
+                        exports["qb-banking"]:CreateJobAccount(society, 0) Wait(150) -- make new account if return "null"
+                    elseif Gangs[society] then
+                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
+                        exports["qb-banking"]:CreateGangAccount(society, 0) Wait(150) -- make new account if return "null"
+                    end
+                end
+                exports["qb-banking"]:RemoveMoney(society, amount)
+            end,
+        fundSociety =
+            function(society, amount)
+                if not exports["qb-banking"]:GetAccount(society) then
+                    if Jobs[society] then
+                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
+                        exports["qb-banking"]:CreateJobAccount(society, 0)
+                        Wait(150)
+                    elseif Gangs[society] then
+                        print("^6Bridge^7: ^2Making new bank account in ^7'^3qb-banking^7' ^2for ^7'^3"..society.."^7'")
+                        exports["qb-banking"]:CreateGangAccount(society, 0)
+                        Wait(150)
+                    end
+                end
+                exports["qb-banking"]:AddMoney(society, amount)
+            end,
+    },
+
+    {   bankName = "esx_society",
+        getAccount =
+            function(society)
+                local checkExist = exports.esx_society:GetSociety(society)
+                if checkExist == nil then
+                    print("^6Bridge^7: ^2Making new bank account in ^7'^3esx_society^7' ^2for ^7'^3"..society.."^7'")
+                    exports.esx_society:registerSociety(
+                        society,
+                        Gangs[society] and Gangs[society].label or Jobs[society] and Jobs[society].label,
+                        society,
+                        society,
+                        society,
+                        {type = "public"}
+                    )
+                end
+                local p = promise.new()
+                TriggerEvent('esx_addonaccount:getSharedAccount', checkExist.account, function(account)
+                    p:resolve(account.money)
+                end)
+                local newAmount = Citizen.Await(p)
+                return newAmount
+            end,
+        chargeSociety =
+            function(society, amount)
+                local checkExist = exports.esx_society:GetSociety(society)
+                if checkExist == nil then
+                    print("^6Bridge^7: ^2Making new bank account in ^7'^3esx_society^7' ^2for ^7'^3"..society.."^7'")
+                    exports.esx_society:registerSociety(
+                        society,
+                        Gangs[society] and Gangs[society].label or Jobs[society] and Jobs[society].label,
+                        society,
+                        society,
+                        society,
+                        {type = "public"}
+                    )
+                end
+                TriggerEvent('esx_addonaccount:getSharedAccount', checkExist.account, function(account)
+                    if amount > 0 and account.money >= amount then
+                        account.removeMoney(amount)
+                    end
+                end)
+            end,
+        fundSociety =
+            function(society, amount)
+                local checkExist = exports.esx_society:GetSociety(society)
+                if checkExist == nil then
+                    print("^6Bridge^7: ^2Making new bank account in ^7'^3esx_society^7' ^2for ^7'^3"..society.."^7'")
+                    exports.esx_society:registerSociety(
+                        society,
+                        Gangs[society] and Gangs[society].label or Jobs[society] and Jobs[society].label,
+                        society,
+                        society,
+                        society,
+                        {type = "public"}
+                    )
+                end
+                TriggerEvent('esx_addonaccount:getSharedAccount', checkExist.account, function(account)
+                    account.addMoney(amount)
+                end)
+            end,
+    },
+
 }
 
 
@@ -200,14 +263,4 @@ function fundSociety(society, amount)
     end
 
     print("^1Error^7: ^3FundSociety^7: ^2No supported banking script found")
-end
-
-
--- other
-if isStarted("esx_society") then
-    createCallback(getScript()..":getESXSocietyAccount", function(source, society)
-        -- Example query – adjust table/field names to match your esx_society implementation.
-        local result = MySQL.scalar.await('SELECT money FROM society_money WHERE society = ?', { society })
-        return result or 0
-    end)
 end

shared/targets.lua

@@ -33,7 +33,7 @@ local targetFunc = {
                         canInteract = opts[i].canInteract or nil,
                     }
                 end
-                exports[OXTargetExport]:addLocalEntity(entity, options)
+                return exports[OXTargetExport]:addLocalEntity(entity, options)
             end,
 
         boxTarget =
@@ -105,7 +105,7 @@ local targetFunc = {
                         canInteract = opts[i].canInteract or nil,
                     }
                 end
-                exports[OXTargetExport]:addModel(models, options)
+                return exports[OXTargetExport]:addModel(models, options)
             end,
 
         removeTargetEntity =
@@ -128,7 +128,7 @@ local targetFunc = {
         entityTarget =
             function(entity, opts, dist)
                 local options = { options = opts, distance = dist }
-                exports[QBTargetExport]:AddTargetEntity(entity, options)
+                return exports[QBTargetExport]:AddTargetEntity(entity, options)
             end,
 
         boxTarget =
@@ -148,7 +148,7 @@ local targetFunc = {
         modelTarget =
             function(models, opts, dist)
                 local options = { options = opts, distance = dist }
-                exports[QBTargetExport]:AddTargetModel(models, options)
+                return exports[QBTargetExport]:AddTargetModel(models, options)
             end,
 
         removeTargetEntity =
@@ -213,11 +213,10 @@ local targetFunc = {
 
 
 -- Tables for storing created targets for the fallback system and zone management.
-local TextTargets    = {}   -- For fallback DrawText3D targets.
 local targetEntities = {}   -- For entity targets.
 local boxTargets     = {}   -- For box-shaped zone targets.
 local circleTargets  = {}   -- For circular zone targets.
-
+local modelTargets   = {}
 -------------------------------------------------------------
 -- Entity Target Creation
 -------------------------------------------------------------
@@ -442,7 +441,7 @@ function createModelTarget(models, opts, dist)
         if isStarted(script.targetName) then
             debugPrint("^6Bridge^7: ^2Creating new ^3Model ^2target with ^6"..script.targetName.."^7")
             local target = script.modelTarget(models, opts, dist)
-            circleTargets[#circleTargets + 1] = target
+            modelTargets[#modelTargets + 1] = target
             return target
         end
     end
@@ -553,7 +552,7 @@ local function CleanupTargets()
         if isStarted(OXTargetExport) then
             exports[OXTargetExport]:removeZone(boxTargets[i], true)
         elseif isStarted(QBTargetExport) then
-            exports[QBTargetExport]:RemoveZone(boxTargets[i].name)
+            exports[QBTargetExport]:RemoveZone(boxTargets[i])
         end
     end
     -- Remove circle zone targets.
@@ -561,7 +560,7 @@ local function CleanupTargets()
         if isStarted(OXTargetExport) then
             exports[OXTargetExport]:removeZone(circleTargets[i], true)
         elseif isStarted(QBTargetExport) then
-            exports[QBTargetExport]:RemoveZone(circleTargets[i].name)
+            exports[QBTargetExport]:RemoveZone(circleTargets[i])
         end
     end
 end

shared/wrapperfunctions.lua

@@ -1,4 +1,3 @@
-
 --- Registers a command with the active command system.
 --- This function supports multiple command systems (OXLib, qb-core, ESX Legacy).
 ---
@@ -47,7 +46,7 @@ function registerCommand(command, options)
             optionTable.helpInfo,
             optionTable.subText,
             optionTable.argsRequired,
-            optionTable.funt,
+            optionTable.funct,
             optionTable.restriction or nil
         )
 
@@ -57,7 +56,7 @@ function registerCommand(command, options)
             optionTable.helpInfo,
             optionTable.subText,
             optionTable.argsRequired,
-            optionTable.funt,
+            optionTable.funct,
             optionTable.restriction or nil
         )
 

version.txt

@@ -1,17 +1,9 @@
-2.1.01
+2.1.02
 
 - Script Overhaul, replace whole script
-- Very alpha support for VorpCore
-- Improve security
 - Removal of Quasar Script Support
 - Support Tgiann-inv's new item system
-- Refactor most multi-functions to be more optimized and smarter
-- Added multifunction bossmenu and clothing functions
-- Added ability to supress update notifcations in fxmanfiest.lua
-- Added coordinate checks to registerStash, registerShop and sellShop
-- Optimize and Enhance built-in progressbar + target functions
-- Improve weird multicharacter issue triggering onPlayerLoaded more than once
-- Scripts that use this will need updating too, as things like stashes won't open
 - **Hotfix for stores and stashes not registering properly**
+- **Hotfix "nil" print and use .xy for distance check**
 
 https://github.com/jimathy/jim_bridge/releases/latest