Hotfix for shops and stashes erroring

This should fix the `jim_bridge` side of the reports of stores erroring when scripts starts

fxmanifest.lua

@@ -1,6 +1,6 @@
 name "Jim_Bridge"
 author "Jimathy"
-version "2.0.23"
+version "2.1.01"
 description "Framework Bridge By Jimathy"
 fx_version "cerulean"
 rdr3_warning 'I acknowledge that this is a prerelease build of RedM, and I am aware my resources *will* become incompatible once RedM ships.'

shared/callback.lua

@@ -25,7 +25,6 @@ local function awaitWithTimeout(registerFn, timeoutMs)
     return nil, res
 end
 
-
 --- Registers a callback function with the appropriate framework.
 ---
 --- This function checks which framework is started (e.g., OX, QB, ESX) and registers the callback accordingly.

shared/itemcontrol.lua

@@ -2104,9 +2104,7 @@ end
 function openStash(data)
     if (data.job or data.gang) and not jobCheck(data.job or data.gang) then return end
 
-    local p = promise.new()
-    p:resolve(triggerCallback(getScript()..":getRegisteredStashLocations", data.stash))
-    local exploitCheck = Citizen.Await(p)
+    local exploitCheck = triggerCallback(getScript()..":getRegisteredStashLocations", data.stash)
 
     if not exploitCheck then
         print("^3Warning^7: ^2This isn't a registered stash^1, refusing call^7")
@@ -2351,19 +2349,23 @@ end
 --- )
 --- ```
 function registerStash(name, label, slots, weight, owner, coords)
-    if coords then
-        stashExploitCheck[name] = stashExploitCheck[name] or {}
-        stashExploitCheck[name][#stashExploitCheck[name]+1] = coords
-    else
-        print("^3Warning^7: ^1Stash ^4"..name.." ^1doesn^7'^1t have coords^7, ^1this is exploitable^7, ^1add coords to ^3regiterStash^7()")
-    end
+
+    -- ensure tables exist
+    stashExploitCheck = stashExploitCheck or {}
+    stashExploitCheck[name] = stashExploitCheck[name] or {}
     for i = 1, #InvFunc do
         local inv = InvFunc[i]
         if isStarted(inv.invName) then
             inv.registerStash(name, label, slots, weight, owner, coords)
-            return
+            break
         end
     end
+
+    if coords then
+        stashExploitCheck[name][#stashExploitCheck[name]+1] = coords.xyz
+    else
+        print("^3Warning^7: ^1Stash ^4"..name.." ^1doesn^7'^1t have coords^7, ^1this is exploitable^7, ^1add coords to ^3regiterStash^7()")
+    end
 end
 
 if isServer() then
@@ -2689,6 +2691,9 @@ end)
 --- ```
 function registerShop(name, label, items, society, coords)
     local shopResource = ""
+    -- ensure tables exist
+    shopExploitCheck = shopExploitCheck or {}
+    shopExploitCheck[name] = shopExploitCheck[name] or {}
 
     for i = 1, #InvFunc do
         local inv = InvFunc[i]
@@ -2700,9 +2705,7 @@ function registerShop(name, label, items, society, coords)
     end
 
     -- If received coords, pass them to distance check cache
-    if coords and type(coords) == "vector3" then
-        --print("Registered Shop Correctly")
-        shopExploitCheck[name] = shopExploitCheck[name] or {}
+    if coords then
         shopExploitCheck[name][#shopExploitCheck[name]+1] = coords
     else
         print("^3Warning^7: ^1Store ^4"..name.." ^1doesn^7'^1t have coords^7, ^1this is exploitable^7, ^1add coords to ^3regiterShop^7()")

shared/playerfunctions.lua

@@ -130,12 +130,13 @@ end)
 --- @param type string "thirst" or "hunger".
 --- @param amount number New value to set.
 RegisterNetEvent(getScript()..":server:setNeed", function(needType, amount)
-    local src = source
-    if needType == "thirst" then
-        setThirst(src, amount)
-    elseif needType == "hunger" then
-        setHunger(src, amount)
-    end
+    print("^1Deprecated function ':server:setNeed' called, please update your scripts^7")
+--    local src = source
+--    if needType == "thirst" then
+--        setThirst(src, amount)
+--    elseif needType == "hunger" then
+--        setHunger(src, amount)
+--    end
 end)
 
 -------------------------------------------------------------
@@ -322,41 +323,42 @@ end
 --- ConsumeSuccess("beer", "alcohol")
 --- ```
 function ConsumeSuccess(itemName, type, data)
-    local hunger = data and data.hunger or Items[itemName].hunger
-    local thirst = data and data.thirst or Items[itemName].thirst
-
-    ExecuteCommand("e c")
-    removeItem(itemName, 1)
-
-    if isStarted(ESXExport) then
-        if hunger then
-            TriggerServerEvent(getScript()..":server:setNeed", "hunger", tonumber(hunger) * 10000)
-        end
-        if thirst then
-            TriggerServerEvent(getScript()..":server:setNeed", "thirst", tonumber(thirst) * 10000)
-        end
-    else
-        if hunger then
-            TriggerServerEvent(getScript()..":server:setNeed", "hunger", Core.Functions.GetPlayerData().metadata["hunger"] + tonumber(hunger))
-        end
-        if thirst then
-            TriggerServerEvent(getScript()..":server:setNeed", "thirst", Core.Functions.GetPlayerData().metadata["thirst"] + tonumber(thirst))
-        end
-    end
-
-    if type == "alcohol" then
-        alcoholCount = (alcoholCount or 0) + 1
-        if alcoholCount > 1 and alcoholCount < 4 then
-            TriggerEvent("evidence:client:SetStatus", "alcohol", 200)
-        elseif alcoholCount >= 4 then
-            TriggerEvent("evidence:client:SetStatus", "heavyalcohol", 200)
-            AlienEffect()
-        end
-    end
-
-    if Config.Reward then
-        getRandomReward(itemName)
-    end
+    print("^1Deprecated function 'ConsumeSuccess' called, please update your scripts^7")
+    --local hunger = data and data.hunger or Items[itemName].hunger
+    --local thirst = data and data.thirst or Items[itemName].thirst
+    --
+    --ExecuteCommand("e c")
+    --removeItem(itemName, 1)
+    --
+    --if isStarted(ESXExport) then
+    --    if hunger then
+    --        TriggerServerEvent(getScript()..":server:setNeed", "hunger", tonumber(hunger) * 10000)
+    --    end
+    --    if thirst then
+    --        TriggerServerEvent(getScript()..":server:setNeed", "thirst", tonumber(thirst) * 10000)
+    --    end
+    --else
+    --    if hunger then
+    --        TriggerServerEvent(getScript()..":server:setNeed", "hunger", Core.Functions.GetPlayerData().metadata["hunger"] + tonumber(hunger))
+    --    end
+    --    if thirst then
+    --        TriggerServerEvent(getScript()..":server:setNeed", "thirst", Core.Functions.GetPlayerData().metadata["thirst"] + tonumber(thirst))
+    --    end
+    --end
+    --
+    --if type == "alcohol" then
+    --    alcoholCount = (alcoholCount or 0) + 1
+    --    if alcoholCount > 1 and alcoholCount < 4 then
+    --        TriggerEvent("evidence:client:SetStatus", "alcohol", 200)
+    --    elseif alcoholCount >= 4 then
+    --        TriggerEvent("evidence:client:SetStatus", "heavyalcohol", 200)
+    --        AlienEffect()
+    --    end
+    --end
+    --
+    --if Config.Reward then
+    --    getRandomReward(itemName)
+    --end
 end
 
 -------------------------------------------------------------
@@ -918,17 +920,10 @@ local wardrobeFunc = {
             end)
         end,
     },
-    {   name = "illenium-appearance",
+    {
+        name = "illenium-appearance",
         openWardrobe = function()
-            exports['illenium-appearance']:startPlayerCustomization(function(appearance)
-                if appearance then
-                    TriggerServerEvent("illenium-appearance:server:saveAppearance", appearance)
-                end
-            end, {
-                components = true, componentConfig = { masks = true, upperBody = true, lowerBody = true, bags = true, shoes = true, scarfAndChains = true, bodyArmor = true, shirts = true, decals = true, jackets = true },
-                props = true, propConfig = { hats = true, glasses = true, ear = true, watches = true, bracelets = true },
-                enableExit = true,
-            })
+            TriggerEvent("illenium-appearance:client:openOutfitMenu")
         end,
     },
 }

version.txt

@@ -1,15 +1,17 @@
-2.0.22
+2.1.01
 
-- Support for qs-interface
-- Fix polyzone minZ + maxZ handling
-- Fix ox_target zone location to match qb-target
-- Fix "Waiting for script start" loop bug
-- Add condition for fading in entities
-- Fix typo breaking scripts on gta skillbar fail
-- Fix typo for gksphone invoice event
-- Fix latio_ui TextUI placement
-- Remove registerShop debug message
-- Fix typo in print when removing codem stash item
-- Fix function typo from origen inv documenation
+- Script Overhaul, replace whole script
+- Very alpha support for VorpCore
+- Improve security
+- Removal of Quasar Script Support
+- Support Tgiann-inv's new item system
+- Refactor most multi-functions to be more optimized and smarter
+- Added multifunction bossmenu and clothing functions
+- Added ability to supress update notifcations in fxmanfiest.lua
+- Added coordinate checks to registerStash, registerShop and sellShop
+- Optimize and Enhance built-in progressbar + target functions
+- Improve weird multicharacter issue triggering onPlayerLoaded more than once
+- Scripts that use this will need updating too, as things like stashes won't open
+- **Hotfix for stores and stashes not registering properly**
 
-https://github.com/jimathy/jim_bridge
+https://github.com/jimathy/jim_bridge/releases/latest