Version Bump

`2.1.08` - `2.1.09`

fxmanifest.lua

@@ -1,6 +1,6 @@
 name "Jim_Bridge"
 author "Jimathy"
-version "2.1.08"
+version "2.1.09"
 description "Framework Bridge By Jimathy"
 fx_version "cerulean"
 rdr3_warning 'I acknowledge that this is a prerelease build of RedM, and I am aware my resources *will* become incompatible once RedM ships.'
@@ -11,7 +11,11 @@ files {
     'starter.lua',
     'shared/*.lua',
     'shared/make/*.lua',
+    'shared/auth/*.lua',
+    'shared/make/*.lua',
+    'shared/modules/*.lua',
     'shared/scaleforms/*.lua',
+    'shared/wrappers/*.lua',
 }
 
 -- Version checker

shared/_authToken.lua

@@ -137,21 +137,31 @@ function distExploitCheck(table, src)
         return false
     end
 
+    local maxDist = 10.0
+    local nearestDist = 999999.0
+    local nearestCoords = nil
+
     local ped = src and GetPlayerPed(src) or PlayerPedId()
     local srcCoords = GetEntityCoords(ped)
-    local allow = false
 
     for i = 1, #table do
-        if #(table[i].xy  - srcCoords.xy) <= 10 then
+
+        local dist2d = #(table[i].xy - srcCoords.xy)
+
+        -- Track the nearestDist
+        if dist2d < nearestDist then
+            nearestDist = dist2d
+            nearestCoords = table[i]
+        end
+
+        if dist2d <= maxDist then
+            debugPrint("^1Found location^7: ^3"..nearestDist.." ^7away from player - "..formatCoord(nearestCoords))
             return true
-        else
-            allow = false
         end
     end
 
-    if not allow then
-        print(src and ("^1Src ^3"..src.." ") or "", "^1Tried to open a registered shop/stash from over the distance limit^7")
-        return false
-    end
+    print(src and ("^1Src ^3"..src.." ") or "", "^1Tried to open a registered shop/stash from over the distance limit^7")
+    print("^1Nearest Possible Location^7: ^3"..nearestDist.." ^7away from player - "..formatCoord(nearestCoords))
+    return false
 
 end

shared/crafting.lua

@@ -121,7 +121,7 @@ function craftingMenu(data)
         for k, v in pairs(Recipes[i]) do
             if not excludeKeys[k] then
                 if not Recipes[i].amount then Recipes[i].amount = 1 end
-                tempCarryTable[k] = tempCarryTable[k] and (tempCarryTable[k] < Recipes[i].amount) or Recipes[i].amount
+                tempCarryTable[k] = math.max(tempCarryTable[k] or 0, Recipes[i].amount)
             end
         end
     end
@@ -434,6 +434,7 @@ function makeItem(origData)
                     anim = "putdown_low",
                     flag = 49,
                     icon = k,
+                    disableMovement = true,
                 }) then
                     TriggerEvent((isStarted(QBInv) and QBInvNew and "qb-" or "")..'inventory:client:ItemBox', Items[k], "use", v)
                 else
@@ -455,6 +456,7 @@ function makeItem(origData)
                 anim = anim,
                 flag = 49,
                 icon = data.item,
+                disableMovement = true,
                 request = true,
             }) then
                 TriggerServerEvent(getScript()..":Crafting:GetItem", data.item, data.craft, data.stashName, metadata, currentToken)
@@ -487,6 +489,7 @@ function makeItem(origData)
             anim = anim,
             flag = 49,
             icon = data.item,
+            disableMovement = true,
             request = true,
         }) then
             data.craft.amount *= craftAmount
@@ -593,4 +596,5 @@ RegisterNetEvent(getScript()..":Crafting:GetItem", function(ItemMake, craftable,
     -- Optionally, add experience here:
     -- for example:
     -- if isStarted("core_skills") then exports["core_skills"]:AddExperience(src, 2) end
-end)
+
+end)

shared/itemcontrol.lua

@@ -1656,6 +1656,10 @@ RegisterNetEvent(getScript()..":server:toggleItem", function(give, item, amount,
 
     local invName = ""
     if give == 0 or give == false then
+        if remamount < 0 then
+            print("^1Error^7: ^7src - ^1Client tried to remove a minus number of item ^7- "..item)
+            return
+        end
         if not hasItem(item, amount or 1, src) then
             dupeWarn(src, item, amount)
 
@@ -1803,6 +1807,7 @@ function getItemMetadata(item, slot, src)
 
     if chosenSlot then
         for k, v in pairs(itemcheck) do
+            v.slot = tonumber(v.slot)
             if v.name == item and v.slot == chosenSlot then
                 lowestSlot = v.slot
                 metadata = itemcheck[k].info or itemcheck[k].metadata or {}
@@ -1811,6 +1816,7 @@ function getItemMetadata(item, slot, src)
         end
     else
         for k, v in pairs(itemcheck) do
+            v.slot = tonumber(v.slot)
             if v.name == item then
                 if v.slot <= lowestSlot then
                     lowestSlot = v.slot

shared/make/cameras.lua

@@ -19,7 +19,7 @@ local camCache = {}
 -- ```
 function createTempCam(ent, coords)
 	local camID = nil
-	if Config.Crafting?.craftCam or Config.System.enableCam then
+	if (Config.Crafting and Config.Crafting.craftCam) or Config.System.enableCam then
 
 		-- if not ent or coords are provided, make a basic camera to control later
 		if not ent and not coords then

shared/notify.lua

@@ -111,7 +111,10 @@ local notifyFunc = {
 --- triggerNotify("Alert", "You have been warned for misconduct.", "error", playerId)
 --- ```
 function triggerNotify(title, message, type, src)
-    if not Config.System?.Notify then debugPrint("Notify triggered but not set up") return end
+    if not Config or not Config.System or not Config.System.Notify then
+        print("Notify triggered but not set up")
+        return
+    end
 
     if src then
         notifyFunc[Config.System.Notify].server(title, message, type, src)

shared/playerfunctions.lua

@@ -392,41 +392,6 @@ end
 --- ```
 function ConsumeSuccess(itemName, type, data)
     print("^1Deprecated function 'ConsumeSuccess' called, please update your scripts^7")
-    --local hunger = data and data.hunger or Items[itemName].hunger
-    --local thirst = data and data.thirst or Items[itemName].thirst
-    --
-    --ExecuteCommand("e c")
-    --removeItem(itemName, 1)
-    --
-    --if isStarted(ESXExport) then
-    --    if hunger then
-    --        TriggerServerEvent(getScript()..":server:setNeed", "hunger", tonumber(hunger) * 10000)
-    --    end
-    --    if thirst then
-    --        TriggerServerEvent(getScript()..":server:setNeed", "thirst", tonumber(thirst) * 10000)
-    --    end
-    --else
-    --    if hunger then
-    --        TriggerServerEvent(getScript()..":server:setNeed", "hunger", Core.Functions.GetPlayerData().metadata["hunger"] + tonumber(hunger))
-    --    end
-    --    if thirst then
-    --        TriggerServerEvent(getScript()..":server:setNeed", "thirst", Core.Functions.GetPlayerData().metadata["thirst"] + tonumber(thirst))
-    --    end
-    --end
-    --
-    --if type == "alcohol" then
-    --    alcoholCount = (alcoholCount or 0) + 1
-    --    if alcoholCount > 1 and alcoholCount < 4 then
-    --        TriggerEvent("evidence:client:SetStatus", "alcohol", 200)
-    --    elseif alcoholCount >= 4 then
-    --        TriggerEvent("evidence:client:SetStatus", "heavyalcohol", 200)
-    --        AlienEffect()
-    --    end
-    --end
-    --
-    --if Config.Reward then
-    --    getRandomReward(itemName)
-    --end
 end
 
 -------------------------------------------------------------
@@ -613,6 +578,7 @@ local getPlayerFunc = {
                 local Player = {}
                 local info = ESX.GetPlayerFromId(src)
                 if not info then return {} end
+
                 Player = {
                     name = info.getName(),
                     cash = info.getMoney(),
@@ -629,8 +595,8 @@ local getPlayerFunc = {
                     onDuty = info.job.onDuty,
                     --account = info.charinfo.account,
                     citizenId = info.identifier,
-                    hunger = info.status.hunger,
-                    thirst = info.status.thirst,
+                    hunger = Player(src).state.hunger or 0,
+                    thirst = Player(src).state.thirst or 0,
                 }
                 return Player
             end,
@@ -646,6 +612,7 @@ local getPlayerFunc = {
                     if v.name == "money" then cash = v.money end
                     if v.name == "bank" then bank = v.money end
                 end
+
                 Player = {
                     firstname = info.firstName,
                     lastname = info.lastName,
@@ -662,8 +629,8 @@ local getPlayerFunc = {
                     citizenId = info.identifier,
                     isDead = IsEntityDead(PlayerPedId()),
                     isDown = IsPedDeadOrDying(PlayerPedId(), true),
-                    hunger = info.status.hunger,
-                    thirst = info.status.thirst,
+                    hunger = LocalPlayer.state.hunger or 0,
+                    thirst = LocalPlayer.state.thirst or 0,
                 }
                 return Player
             end,

version.txt

@@ -1,10 +1,14 @@
-2.1.08
+2.1.09
 
-- Fix getStash() always trying to use fallback functions
-- Start adding stashEditMetadata() function - wip
-- Add check for broken/missing config.lua in scripts
-- Add fix for debugMode breaking if no config file
-- Add a callback to check for society bank balances
-- Add player head movement for `lookEnt()` to continue looking after turning
+- Add 100 wait for stopCam to reduce slow movement
+- Add support for rcore_clothing in openClothing() - Thanks desypher
+- Add hunger and thirst calls to getPlayer() - Thanks oosayeroo
+- Add support for tgg-billing - Thanks GhostInLowGear
+- Fix hasJob() checking players who haven't logged in yet
+- Add exploit possibility for removeItem with minus numbers
+- Fix movement being allowed when crafting
+- Make distExploitCheck() more verbose
+- CodeM slot fix, force to number (because numbers are apparently strings)
+- ESX change to check statebag for hunger and thirst info
 
 https://github.com/jimathy/jim_bridge/releases/latest