Update fxmanifest.lua

Had to rewrite the code for grabbing the player list

All on client side now and no callbacks

README.md

@@ -1,6 +1,10 @@
 # jim-payments
 QBCore based payment system
 
+--------------
+If you use a different phone/invoice system let me know and I will add support for it as best I can!
+--------------
+
 Enchanced QB-Input payment system from my other scripts now free on its own
 
 ![General](https://i.imgur.com/37d2mE3.jpeg) ![General](https://i.imgur.com/ICbQyeQ.jpeg)
@@ -41,3 +45,7 @@ Go to [qb] > qb-phone > client > main.lua
 - Add this line:
 
 ```TriggerServerEvent('jim-payments:Tickets:Give', amount, society)```
+
+--------------
+
+NOTE: If you are converting from my older job scripts, I recommend removing the previous triggers from qb-phone

client.lua

@@ -36,27 +36,32 @@ end)
 
 RegisterNetEvent('jim-payments:client:Charge', function()
 	if not onDuty then TriggerEvent("QBCore:Notify", "Not Clocked in!", "error") return end  -- Require to be on duty when making a payment
-    QBCore.Functions.TriggerCallback('jim-payments:server:GetCurrentPlayers', function(playerList)
-	if playerList[1] == nil then TriggerEvent("QBCore:Notify", "No one near by to charge", "error") return end
-		local dialog = exports['qb-input']:ShowInput({ header = "Charge Customer", submitText = "Send",
-		inputs = {
-				{ text = "Citizen",	name = "citizen", type = "select", options = playerList	},				
-				{ type = 'number', isRequired = true, name = 'price', text = 'Amount to Charge' },
-				{ type = 'radio', name = 'billtype', text = 'Payment Type', options = {	{ value = "cash", text = "Cash" }, { value = "card", text = "Card" } } }, }
-		})
-		if dialog then
-			if not dialog.citizen or not dialog.price then return end
-			TriggerServerEvent('jim-payments:server:Charge', dialog.citizen, dialog.price, dialog.billtype)
+	local playerList = {}
+	for k,v in pairs(QBCore.Functions.GetPlayersFromCoords(GetEntityCoords(PlayerPedId()), Config.PaymentRadius)) do
+		dist = #(GetEntityCoords(GetPlayerPed(v)) - GetEntityCoords(PlayerPedId()))
+		TriggerEvent("QBCore:Notify", "["..GetPlayerServerId(v).."] - "..GetPlayerName(v).." ("..math.floor(dist+0.5).."m)", "error")
+		if v ~= PlayerId() then
+			playerList[#playerList+1] = { value = GetPlayerServerId(v), text = "["..GetPlayerServerId(v).."] - "..GetPlayerName(v).." ("..math.floor(dist+0.5).."m)" }
 		end
-	end)
+	end    
+	if playerList[1] == nil then TriggerEvent("QBCore:Notify", "No one near by to charge", "error") return end
+	local dialog = exports['qb-input']:ShowInput({ header = "Charge Customer", submitText = "Send",
+	inputs = {
+			{ text = "Citizen", name = "citizen", type = "select", options = playerList    },                
+			{ type = 'number', isRequired = true, name = 'price', text = 'Amount to Charge' },
+			{ type = 'radio', name = 'billtype', text = 'Payment Type', options = { { value = "cash", text = "Cash" }, { value = "card", text = "Card" } } }, }
+	})
+	if dialog then
+		if not dialog.citizen or not dialog.price then return end
+		TriggerServerEvent('jim-payments:server:Charge', dialog.citizen, dialog.price, dialog.billtype)
+	end
 end)
-
 RegisterNetEvent('jim-payments:Tickets:Menu', function()
 	for k, v in pairs(Config.Jobs) do if k ~= PlayerJob.name then 
 		else exports['qb-menu']:openMenu({
-				{ isMenuHeader = true, header = PlayerJob.label.." Ticket Payment", txt = "Do you want trade your tickets for payment?" },
-				{ header = "Yes", txt = "", params = { event = "jim-payments:Tickets:Sell:yes" } },
-				{ header = "No", txt = "", params = { event = "jim-payments:Tickets:Sell:no" } }, })
+			{ isMenuHeader = true, header = PlayerJob.label.." Ticket Payment", txt = "Do you want trade your tickets for payment?" },
+			{ header = "Yes", txt = "", params = { event = "jim-payments:Tickets:Sell:yes" } },
+			{ header = "No", txt = "", params = { event = "jim-payments:Tickets:Sell:no" } }, })
 		end
 	end
 end)

config.lua

@@ -1,4 +1,4 @@
-print("Jim-Payments v1.0 - Payments Script by Jimathy")
+print("Jim-Payments v1.1 - Payments Script by Jimathy")
 
 -- If you need support I now have a discord available, it helps me keep track of issues and give better support.
 
@@ -17,4 +17,4 @@ Config.Jobs = {
 	['tequilala'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
 	['vanilla'] = { MinAmountforTicket = 50, PayPerTicket = 50 },
 	['mechanic'] = { MinAmountforTicket = 1000, PayPerTicket = 500 },
-}
+}

fxmanifest.lua

@@ -1,6 +1,6 @@
 name "Jim-Payments"
 author "Jimathy"
-version "v1.1"
+version "v1.2"
 description "Payment Script By Jimathy"
 fx_version "cerulean"
 game "gta5"

server.lua

@@ -70,7 +70,7 @@ QBCore.Functions.CreateCallback('jim-payments:server:GetCurrentPlayers', functio
 		local Player = QBCore.Functions.GetPlayer(v)
 		if Player ~= nil and v ~= source then
 			local dist = #(vector3(Player.PlayerData.position.x, Player.PlayerData.position.y, Player.PlayerData.position.z) - vector3(SPlayer.PlayerData.position.x, SPlayer.PlayerData.position.y, SPlayer.PlayerData.position.z))
-			if dist <= Config.PaymentRadius then onlineList[#onlineList+1] = { value = tonumber(v), text = "["..v.."] - "..Player.PlayerData.charinfo.firstname..' '..Player.PlayerData.charinfo.lastname..' ('..dist..'m)' }
+			if dist <= Config.PaymentRadius then onlineList[#onlineList+1] = { value = tonumber(v), text = "["..v.."] - "..Player.PlayerData.charinfo.firstname..' '..Player.PlayerData.charinfo.lastname..' ('..math.floor(dist+0.5)..'m)' }
 			elseif dist > Config.PaymentRadius then end
 		end
 	end