Update fxmanifest.lua

fix: not getting discord info on player connecting

README.md

@@ -16,9 +16,13 @@
 * [oxmysql](https://github.com/overextended/oxmysql/releases)
 * [ox_lib](https://github.com/overextended/ox_lib/releases)
 
-## v2 Addons
-* [Character selection](https://github.com/ND-Framework/ND_Characters/tree/wip-v2)
-* [Banking](https://github.com/ND-Framework/ND_Banking/tree/wip-v2)
-* [Appearance shops](https://github.com/ND-Framework/ND_AppearanceShops/tree/wip-v2)
-* [Dealership](https://github.com/ND-Framework/ND_Dealership/tree/v2)
-* [Inventory](https://github.com/overextended/ox_inventory/pull/1403)
+## Addons
+* [Character selection](https://github.com/ND-Framework/ND_Characters/releases)
+* [Banking](https://github.com/ND-Framework/ND_Banking/releases)
+* [Appearance shops](https://github.com/ND-Framework/ND_AppearanceShops/releases)
+* [Dealership](https://github.com/ND-Framework/ND_Dealership/releases)
+* [Inventory](https://github.com/overextended/ox_inventory/releases)
+* [Ambulance job](https://github.com/ND-Framework/ND_Ambulance/releases)
+* [Casino](https://github.com/ND-Framework/ND_Casino/releases)
+* [Blackjack](https://github.com/ND-Framework/ND_Blackjack/releases)
+* [Nitro](https://github.com/ND-Framework/ND_Nitro/releases)

config_client.lua

@@ -1,74 +0,0 @@
--- For support join my discord: https://discord.gg/Z9Mxu72zZ6
-
-config = {
-    serverName = "Andy's Development",
-    characterLimit = 15, -- How many characters can a player create.
-    customPauseMenu = true, -- A custom pause menu will display your money, characters name and the server name in the pause menu.
-    enablePVP = true, -- pvp allows doing damage to other players.
-    
-    -- Money related
-    startingCash = 2500, -- default cash the character will start with if the character creator doesn't specify it.
-    startingBank = 8000,-- default money in the bank account the character will start with if the character creator doesn't specify it.
-    
-    -- If you'd like to whitelist certain roles on discord then set this to true and add role ids.
-    enableDiscordWhitelist = false,
-    notWhitelistedMessage = "You're not allowlisted in this server please join our discord to apply for a allowlist: https://discord.gg/Z9Mxu72zZ6",
-    whitelistRoles = {
-        "872921520719142932"
-    },
-
-    -- These are admins roles that will give a user permission to admin commands and more.
-    adminRoles = {
-        "872921520719142932"
-    },
-
-    -- Discord Rich presence
-    enableRichPresence = true,
-    updateIntervall = 60, -- how many seconds of delay until it updates status.
-    appId = 858146067018416128,
-    largeLogo = "andyyy",
-    smallLogo = "andyyy",
-    firstButtonName = "DISCORD",
-    firstButtonLink = "https://discord.gg/Z9Mxu72zZ6",
-    secondButtonName = "TEBEX",
-    secondButtonLink = "https://andyyy.tebex.io/category/fivem-scripts",
-
-
-    -- Groups can be gangs, jobs, subdivisions, etc.
-    groups = {
-        ["Ballas"] = {
-            "Member", -- rank 1
-            "Boss" -- rank 2
-        },
-        ["SWAT"] = {
-            "Member", -- rank 1
-            "Sniper", -- rank 2
-            "Team lead", -- rank 3
-            "Commander" -- rank 4
-        },
-        ["SAHP"] = {
-            "Trooper",
-            "Senior Trooper",
-            "Corporal",
-            "Sergeant",
-            "Lieutenant",
-            "Cheif"
-        },
-        ["LSPD"] = {
-            "Officer",
-            "Senior officer",
-            "Corporal",
-            "Sergeant",
-            "Lieutenant",
-            "Cheif"
-        },
-        ["BCSO"] = {
-            "Deputy",
-            "Senior Deputy",
-            "Corporal",
-            "Sergeant",
-            "Lieutenant",
-            "Cheif"
-        }
-    },
-}

config_server.lua

@@ -1,6 +0,0 @@
--- For support join my discord: https://discord.gg/Z9Mxu72zZ6
-
-server_config = {
-    discordServerToken = "OTAwODg1MDMxMDQ2Nzc0ODQ1.GU1TSC.Ed8D2_wcU-UQ1vZhe1khahgV8J3hLahOp4N1D8", -- discord bot token for permissions
-    guildId = "872496972454592523", -- discord guild id
-}

database/characters.sql

@@ -8,8 +8,8 @@ CREATE TABLE IF NOT EXISTS `nd_characters` (
 	`gender` VARCHAR(50) DEFAULT NULL,
 	`cash` INT(10) DEFAULT '0',
 	`bank` INT(10) DEFAULT '0',
-	`groups` LONGTEXT DEFAULT '[]',
-	`metadata` LONGTEXT DEFAULT '[]',
-	`inventory` LONGTEXT DEFAULT '[]',
+	`groups` LONGTEXT DEFAULT ('[]'),
+	`metadata` LONGTEXT DEFAULT ('[]'),
+	`inventory` LONGTEXT DEFAULT ('[]'),
 	PRIMARY KEY (`charid`) USING BTREE
 );

database/vehicles.sql

@@ -2,13 +2,13 @@ CREATE TABLE IF NOT EXISTS `nd_vehicles` (
 	`id` INT(11) NOT NULL AUTO_INCREMENT,
 	`owner` INT(11) DEFAULT NULL,
 	`plate` VARCHAR(255) DEFAULT NULL,
-	`glovebox` LONGTEXT DEFAULT '[]',
-	`trunk` LONGTEXT DEFAULT '[]',
-	`properties` LONGTEXT DEFAULT '[]',
+	`glovebox` LONGTEXT DEFAULT ('[]'),
+	`trunk` LONGTEXT DEFAULT ('[]'),
+	`properties` LONGTEXT DEFAULT ('[]'),
     `stored` INT(11) DEFAULT '1',
 	`impounded` INT(11) DEFAULT '0',
 	`stolen` INT(11) DEFAULT '0',
-    `metadata` LONGTEXT DEFAULT '[]',
+    `metadata` LONGTEXT DEFAULT ('[]'),
 	PRIMARY KEY (`id`) USING BTREE,
 	INDEX `owner` (`owner`) USING BTREE,
 	CONSTRAINT `vehowner` FOREIGN KEY (`owner`) REFERENCES `nd_characters` (`charid`) ON UPDATE CASCADE ON DELETE CASCADE

fxmanifest.lua

@@ -2,7 +2,7 @@
 
 author "Andyyy#7666"
 description "ND Framework Core"
-version "2.0.0"
+version "2.0.1"
 
 fx_version "cerulean"
 game "gta5"
@@ -38,5 +38,7 @@ files {
 }
 
 dependency "oxmysql"
+
+-- below were used with backwards compatibility but could interfere with resources checking if the resources are started.
 -- provide "es_extended"
 -- provide "qb-Core"

server/events.lua

@@ -1,117 +0,0 @@
--- For support join my discord: https://discord.gg/Z9Mxu72zZ6
-
--- Check if discord is connected, and if whitelist is enabled then it will only allow you to join if you have the roles.
-AddEventHandler("playerConnecting", function(name, setKickReason, deferrals)
-    local player = source
-    local discordIdentifier = NDCore.Functions.GetPlayerIdentifierFromType("discord", player)
-
-    deferrals.defer()
-    Wait(0)
-    deferrals.update("Connecting to discord.")
-    Wait(0)
-
-    if not discordIdentifier then
-        deferrals.done("Your discord isn't connected to FiveM, make sure discord is open and restart FiveM.")
-    else
-        if config.enableDiscordWhitelist then
-            local discordUserId = discordIdentifier:gsub("discord:", "")
-            local discordInfo = NDCore.Functions.GetUserDiscordInfo(discordUserId)
-            for _, whitelistRole in pairs(config.whitelistRoles) do
-                if whitelistRole == 0 or whitelistRole == "0" or (discordInfo and discordInfo.roles[whitelistRole]) then
-                    deferrals.done()
-                    break
-                end
-            end
-            deferrals.done(config.notWhitelistedMessage)
-        else
-            deferrals.done()
-        end
-    end
-end)
-
--- Getting all the characters the player has and returning them to the client.
-RegisterNetEvent("ND:GetCharacters", function()
-    local player = source
-    TriggerClientEvent("ND:returnCharacters", player, NDCore.Functions.GetPlayerCharacters(player))
-end)
-
--- Creating a new character.
-RegisterNetEvent("ND:newCharacter", function(newCharacter)
-    local player = source
-    NDCore.Functions.CreateCharacter(player, newCharacter.firstName, newCharacter.lastName, newCharacter.dob, newCharacter.gender, newCharacter.cash, newCharacter.bank)
-end)
-
--- Update the character info when edited.
-RegisterNetEvent("ND:editCharacter", function(newCharacter)
-    local player = source
-    local characters = NDCore.Functions.GetPlayerCharacters(player)
-    if not characters[newCharacter.id] then return end
-    NDCore.Functions.UpdateCharacterData(newCharacter.id, newCharacter.firstName, newCharacter.lastName, newCharacter.dob, newCharacter.gender)
-end)
-
--- Delete character from database.
-RegisterNetEvent("ND:deleteCharacter", function(characterId)
-    local player = source
-    local characters = NDCore.Functions.GetPlayerCharacters(player)
-    if not characters[characterId] then return end
-    NDCore.Functions.DeleteCharacter(characterId)
-end)
-
--- add a player to the table.
-RegisterNetEvent("ND:setCharacterOnline", function(id)
-    local player = source
-    local characters = NDCore.Functions.GetPlayerCharacters(player)
-    if not characters[id] then return end
-    NDCore.Functions.SetActiveCharacter(player, id)
-end)
-
--- Update the characters clothes.
-RegisterNetEvent("ND:updateClothes", function(clothing)
-    local player = source
-    local character = NDCore.Players[player]
-    NDCore.Functions.SetPlayerData(character.id, "clothing", clothing)
-end)
-
--- Disconnecting a player
-RegisterNetEvent("ND:exitGame", function()
-    local player = source
-    DropPlayer(player, "Disconnected.")
-end)
-
--- Remove player from NDCore.Players table when they leave.
-AddEventHandler("playerDropped", function()
-    local player = source
-    local character = NDCore.Players[player]
-    if character then
-        local ped = GetPlayerPed(player)
-        local lastLocation = GetEntityCoords(ped)
-        NDCore.Functions.UpdateLastLocation(character.id, {x = lastLocation.x, y = lastLocation.y, z = lastLocation.z})
-    end
-    TriggerEvent("ND:characterUnloaded", player, character)
-    character = nil
-end)
-
--- Get player discord info on join.
-AddEventHandler("playerJoining", function()
-    local src = source
-
-    local discordUserId = NDCore.Functions.GetPlayerIdentifierFromType("discord", src):gsub("discord:", "")
-    local discordInfo = NDCore.Functions.GetUserDiscordInfo(discordUserId)
-
-    NDCore.PlayersDiscordInfo[src] = discordInfo
-end)
-
-AddEventHandler("onResourceStart", function(resourceName)
-    if (GetCurrentResourceName() ~= resourceName) then
-        return
-    end 
-    Wait(1000)
-
-    if not next(NDCore.PlayersDiscordInfo) then
-        for _, playerId in ipairs(GetPlayers()) do
-            local discordUserId = NDCore.Functions.GetPlayerIdentifierFromType("discord", playerId):gsub("discord:", "")
-            local discordInfo = NDCore.Functions.GetUserDiscordInfo(discordUserId)
-            NDCore.PlayersDiscordInfo[tonumber(playerId)] = discordInfo
-        end
-    end
-end)

server/main.lua

@@ -46,8 +46,9 @@ end
 
 AddEventHandler("playerJoining", function(oldId)
     local src = source
-    PlayersInfo[src] = tempPlayersInfo[oldId]
-    tempPlayersInfo[oldId] = nil
+    local oldTempId = tonumber(oldId)
+    PlayersInfo[src] = tempPlayersInfo[oldTempId]
+    tempPlayersInfo[oldTempId] = nil
 
     if Config.multiCharacter then return end
     Wait(3000)
@@ -93,12 +94,12 @@ AddEventHandler("playerConnecting", function(name, setKickReason, deferrals)
     local tempSrc = source
     local identifiers = getIdentifierList(tempSrc)
     local mainIdentifier = identifiers[Config.characterIdentifier]
-    local discordInfo = {}
+    local discordInfo = nil
 
     deferrals.defer()
     Wait(0)
 
-    if mainIdentifier and Config.discordBotToken ~= "false" and Config.discordGuildId ~= "false" and not discordInfo then
+    if mainIdentifier and Config.discordBotToken ~= "false" and Config.discordGuildId ~= "false" then
         discordInfo = checkDiscordIdentifier(identifiers)
         if not discordInfo then
             deferrals.done(("Your discord was not found, join our discord here: %s."):format(Config.discordInvite))

server/player.lua

@@ -165,7 +165,7 @@ local function createCharacterTable(info)
     
     -- Save character information to database
     function self.save()
-        local affectedRows = MySQL.update.await("UPDATE nd_characters SET name = ?, firstname = ?, lastname = ?, dob = ?, gender = ?, cash = ?, bank = ?, groups = ?, metadata = ? WHERE charid = ?", {
+        local affectedRows = MySQL.update.await("UPDATE nd_characters SET name = ?, firstname = ?, lastname = ?, dob = ?, gender = ?, cash = ?, bank = ?, `groups` = ?, metadata = ? WHERE charid = ?", {
             self.name,
             self.firstname,
             self.lastname,
@@ -398,7 +398,7 @@ function NDCore.newCharacter(src, info)
         inventory = info.inventory or {},
     }
 
-    charInfo.id = MySQL.insert.await("INSERT INTO nd_characters (identifier, name, firstname, lastname, dob, gender, cash, bank, groups, metadata) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", {
+    charInfo.id = MySQL.insert.await("INSERT INTO nd_characters (identifier, name, firstname, lastname, dob, gender, cash, bank, `groups`, metadata) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", {
         identifier,
         charInfo.name,
         charInfo.firstname,

server/vehicle.lua

@@ -567,8 +567,12 @@ RegisterNetEvent("ND_Vehicles:toggleVehicleLock", function(netId)
 end)
 
 -- locking of npc vehicles, if the players spawns inside a vehicle it won't be locked.
-RegisterNetEvent("entityCreated", function(entity)
+AddEventHandler("entityCreated", function(entity)
+    local time = os.time()
+    while not DoesEntityExist(entity) and os.time()-time < 5 do Wait(50) end
+
     if not DoesEntityExist(entity) or GetEntityType(entity) ~= 2 then return end
+
     local state = Entity(entity).state
     if state.owner or state.locked ~= nil then return end
 

shared/import.lua

@@ -1 +0,0 @@
-NDCore = exports["ND_Core"]:GetCoreObject()

shared/main.lua

@@ -1,30 +0,0 @@
-local startedResources = {}
-local callbacks = {}
-
-AddEventHandler("onResourceStart", function(resourceName)
-    startedResources[resourceName] = true
-    local callback = callbacks[resourceName]
-    if not callback then return end
-    callback(true)
-end)
-
-AddEventHandler("onResourceStop", function(resourceName)
-    startedResources[resourceName] = nil
-    local callback = callbacks[resourceName]
-    if not callback then return end
-    callback(false)
-end)
-
-function isResourceStarted(resourceName, cb)
-    local started = GetResourceState(resourceName) == "started"
-    startedResources[resourceName] = started
-
-    if cb then
-        callbacks[resourceName] = cb
-        cb(started)
-    end
-    
-    return started
-end
-
-exports("isResourceStarted", isResourceStarted)