FumeNodes/ox_lib
1
0
Fork 0
mirror of https://github.com/CommunityOx/ox_lib.git synced 2026-08-18 15:36:02 +01:00
Code Issues Packages Projects Releases Wiki Activity

fix(web/dialog): setting non-selectable placeholder (#67)

Browse Source 
* tweak(interface/menu): SetNuiFocusKeepInput

Default to allow input; disable with "disableInput = false" during registration.

* fix(web/dialog): Setting non-selectable placeholder

React doesn't like the 'selected' attribute (causing a warning in web console - not in-game).

'defaultValue' should be used instead so there is no need to create placeholder option if 'defaultValue' is already defined by row options.

* fix(web/dialog): Use proper type for onChange event

Co-authored-by: Linden <65407488+thelindat@users.noreply.github.com>
This commit is contained in:
ANTOND
2022-08-09 23:37:31 +02:00
committed by GitHub
parent c3726ed924
commit de8fb447a9
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
web/src/features/dialog/components/select.tsx
View File

@@ -23,16 +23,16 @@ const SelectField: React.FC<Props> = (props) => {
<> <>
<Box mb={3} key={`select-${props.index}`}> <Box mb={3} key={`select-${props.index}`}>
<Select <Select
onChange={(e) => props.handleChange(e.target.value, props.index)} onChange={(e: React.ChangeEvent<HTMLSelectElement>) => props.handleChange(e.target.value, props.index)}
defaultValue={props.row.default} defaultValue={props.row.default || ""}
> >
{/* Hacky workaround for selectable placeholder issue */} {/* Hacky workaround for selectable placeholder issue */}
<option value="" selected hidden disabled> {!props.row.default && (<option value="" hidden disabled>
{props.row.label} {props.row.label}
</option> </option>)}
{props.row.options?.map((option, index) => ( {props.row.options?.map((option, index) => (
<option key={`option-${index}`} value={option.value}> <option key={`option-${index}`} value={option.value}>
{option.label ? option.label : option.value} {option.label || option.value}
</option> </option>
))} ))}
</Select> </Select>