FumeNodes/ND_Core
1
0
Fork 0
mirror of https://github.com/ND-Framework/ND_Core.git synced 2026-08-18 14:26:03 +01:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1 from bleachyblue/main

Browse Source 
Validate client cash & bank
This commit is contained in:
Andyyy7666
2022-04-06 23:12:52 +02:00
committed by GitHub
parent 5e8f46271a 05c27c221c
commit e8cd174be4
1 changed files with 23 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
ND_Core/source/server/main.lua
View File

@@ -185,6 +185,18 @@ AddEventHandler("newCharacter", function(newCharacter)
local player = source local player = source
local license = GetPlayerIdentifierFromType("license", player) local license = GetPlayerIdentifierFromType("license", player)
local startingCash = newCharacter.startingCash
local startingBank = newCharacter.startingBank
-- Don't trust the client, validate maximum amounts
local moneyCheck = validateMoney(startingCash, startingBank)
-- Set money to maximum amount in the config
-- Only triggers if the client is sending an amount that exceeds the maximum.
if not moneyCheck then
startingCash = config.maxStartingCash
startingBank = config.maxStartingBank
end
if server_config.SonoranCAD_Enabled then if server_config.SonoranCAD_Enabled then
local steam = string.gsub(GetPlayerIdentifierFromType("steam", player), "steam:", "") local steam = string.gsub(GetPlayerIdentifierFromType("steam", player), "steam:", "")
if newCharacter.gender == "Male" then if newCharacter.gender == "Male" then
@@ -237,6 +249,7 @@ AddEventHandler("newCharacter", function(newCharacter)
if tonumber(character_id) then if tonumber(character_id) then
character_id = character_id + 1 character_id = character_id + 1
end end
kvp[license][character_id] = { kvp[license][character_id] = {
["character_id"] = character_id, ["character_id"] = character_id,
["first_name"] = newCharacter.firstName, ["first_name"] = newCharacter.firstName,
@@ -245,8 +258,8 @@ AddEventHandler("newCharacter", function(newCharacter)
["gender"] = newCharacter.gender, ["gender"] = newCharacter.gender,
["twt"] = newCharacter.twtName, ["twt"] = newCharacter.twtName,
["department"] = newCharacter.department, ["department"] = newCharacter.department,
["cash"] = newCharacter.startingCash, ["cash"] = startingCash,
["bank"] = newCharacter.startingBank ["bank"] = startingBank
} }
SetResourceKvp("ND_Core:Characters", json.encode(kvp)) SetResourceKvp("ND_Core:Characters", json.encode(kvp))
TriggerClientEvent("refreshCharacters", player) TriggerClientEvent("refreshCharacters", player)
@@ -261,7 +274,7 @@ AddEventHandler("newCharacter", function(newCharacter)
else else
character_id = character_id + 1 character_id = character_id + 1
end end
exports.oxmysql:query("INSERT INTO characters (license, character_id, first_name, last_name, dob, gender, twt, department, cash, bank) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", {license, character_id, newCharacter.firstName, newCharacter.lastName, newCharacter.dateOfBirth, newCharacter.gender, newCharacter.twtName, newCharacter.department, newCharacter.startingCash, newCharacter.startingBank}, function(id) exports.oxmysql:query("INSERT INTO characters (license, character_id, first_name, last_name, dob, gender, twt, department, cash, bank) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?)", {license, character_id, newCharacter.firstName, newCharacter.lastName, newCharacter.dateOfBirth, newCharacter.gender, newCharacter.twtName, newCharacter.department, startingCash, startingBank}, function(id)
if id then if id then
exports.oxmysql:query("SELECT * FROM characters WHERE license = ?", {GetPlayerIdentifierFromType("license", player)}, function(result) exports.oxmysql:query("SELECT * FROM characters WHERE license = ?", {GetPlayerIdentifierFromType("license", player)}, function(result)
if result then if result then
@@ -762,3 +775,10 @@ function addMoney(amount, player, to)
end end
end end
end end
function validateMoney(cash, bank)
if tonumber(cash) > config.maxStartingCash or tonumber(bank) > config.maxStartingBank then
return false
end
return true
end